Skip to content

deprecate Axiom-specific options in Velox config objects #779

@hdikeman

Description

@hdikeman

There were some Axiom-specific options added to Velox HiveConfig previously:
https://github.com/facebookincubator/velox/blob/main/velox/connectors/hive/HiveConfig.h#L286

  /// Returns the file system path containing local data. If non-empty,
  /// initializes LocalHiveConnectorMetadata to provide metadata for the tables
  /// in the directory.
  std::string hiveLocalDataPath() const;

  /// Returns the name of the file format to use in interpreting the contents of
  /// hiveLocalDataPath().
  std::string hiveLocalFileFormat() const;

A better structure may be to define _____MetadataConfig objects in the Axiom repository which contain Axiom-specific options. I believe only Hive needs a config object at this point, for the above two options

I will first move Axiom over to HiveMetadataConfig, then open a PR to remove those options from Velox HiveConfig

If there are other preferences for naming please let me know

cc @mbasmanova

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions