fbcode/cinderx/PythonLib/cinderx/compiler/pycodegen.py

Summary:
Remove 5 `pyre-fixme` suppressions in `pycodegen.py` by fixing the underlying type issues:

**`emitAugName` (1 fixme removed):** Added `assert isinstance(target, ast.Name)` to narrow the type of `node.target` from `ast.expr` to `ast.Name`. The caller `visitAugAssign` already guarantees this via an `isinstance` check before dispatching, so this makes the existing assumption explicit for Pyre.

**`emit_try_star_except` (4 fixmes removed):** Bound `handler.name` (typed `str | None`) to a local variable `handler_name` before the existing `if handler_name:` checks. Pyre was losing the `Optional` narrowing across interleaving method calls (`self.emit`, `self.storeName`). The local variable preserves the narrowing without changing control flow.
 ---
> Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/)
[Session](https://www.internalfb.com/confucius?session_id=32fb3408-21bd-11f1-b9cb-85e1b7b3e743&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=32fb3408-21bd-11f1-b9cb-85e1b7b3e743&tab=Trace)

Reviewed By: alexmalyshev, yoney

Differential Revision: D96873199

fbshipit-source-id: 3d606bc572d8609819242f9d74bd49acb5842e94

Author: generatedunixname1386863909833763

cinderx/PythonLib/cinderx/compiler/pycodegen.py

@@ -1414,9 +1414,7 @@ def emitAugRHS(self, node: ast.AugAssign) -> None:
 
     def emitAugName(self, node: ast.AugAssign) -> None:
         target = node.target
-
-        # pyre-fixme[16] This code assumes that the target of the AugAssign is a
-        # Name as opposed to ast.Attribute or ast.Subscript.
+        assert isinstance(target, ast.Name)
         name = target.id
 
         self.loadName(name)
@@ -5446,26 +5444,19 @@ def emit_try_star_except(self, node: ast.TryStar) -> None:
             self.pop_fblock(HANDLER_CLEANUP)
             self.set_no_pos()
             self.emit("POP_BLOCK")
-            if handler.name:
+            handler_name = handler.name
+            if handler_name:
                 self.emit("LOAD_CONST", None)
-                # pyre-fixme[6]: For 1st argument expected `str` but got
-                #  `Optional[str]`.
-                self.storeName(handler.name)
-                # pyre-fixme[6]: For 1st argument expected `str` but got
-                #  `Optional[str]`.
-                self.delName(handler.name)
+                self.storeName(handler_name)
+                self.delName(handler_name)
             self.emit_jump_forward(except_)
 
             # except:
             self.nextBlock(cleanup_end)
-            if handler.name:
+            if handler_name:
                 self.emit("LOAD_CONST", None)
-                # pyre-fixme[6]: For 1st argument expected `str` but got
-                #  `Optional[str]`.
-                self.storeName(handler.name)
-                # pyre-fixme[6]: For 1st argument expected `str` but got
-                #  `Optional[str]`.
-                self.delName(handler.name)
+                self.storeName(handler_name)
+                self.delName(handler_name)
 
             # add exception raised to the res list
             self.emit("LIST_APPEND", 3)