Commit 1514da2
Fix duplicate symbol after Python 3.14.1 upgrade
Summary:
The import of Python 3.14.1 from upstream (D88171463) made `_PyDict_DelItem_KnownHash_LockHeld` in `Objects/dictobject.c` public (no longer static). This caused a duplicate symbol linker error because the borrowing script was still borrowing this function, resulting in two definitions of the function.
We do, however, need to keep borrowing the `_PyDict_DelItem_KnownHash_LockHeld` since it is not actually ever exported (via `PyAPI_FUNC`). To avoid the duplicate definition error, we rename it.
This change removes the `Borrow` directives for both `delitem_knownhash_lock_held` and `_PyDict_DelItem_KnownHash_LockHeld` from the template, since `delitem_knownhash_lock_held` no longer exists and `_PyDict_DelItem_KnownHash_LockHeld` is public.
Reviewed By: itamaro
Differential Revision: D88274838
fbshipit-source-id: 3bd141a1e6d3ed8571a38195df0abdb794b7e3231 parent ba96195 commit 1514da2
2 files changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
145 | 144 | | |
146 | 145 | | |
147 | 146 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
| 98 | + | |
98 | 99 | | |
99 | 100 | | |
100 | 101 | | |
| |||
0 commit comments