Fix LOAD_ASSERITON_ERROR code gen

Summary: 3.14 has moved `LOAD_ASSERTION_ERROR` into a new `LOAD_COMMON_CONSTANT` opcode.

Reviewed By: alexmalyshev

Differential Revision: D80753194

fbshipit-source-id: 0fad1a0e029647a3b2eed28cbfc512ceea418a6b

Author: DinoV

cinderx/PythonLib/cinderx/compiler/pyassem.py

@@ -2213,6 +2213,13 @@ class PyFlowGraphCinder312(PyFlowGraphCinderMixin, PyFlowGraph312):
 
 class PyFlowGraph314(PyFlowGraph312):
     flow_graph_optimizer = FlowGraphOptimizer314
+    _constant_idx = {
+        AssertionError: 0,
+    }
+    _converters: dict[str, Callable[[PyFlowGraph, object], int]] = {
+        **PyFlowGraph312._converters,
+        "LOAD_COMMON_CONSTANT": lambda self, val: PyFlowGraph314._constant_idx[val],
+    }
 
     def instrsize(self, opname: str, oparg: int) -> int:
         base_size = _inline_cache_entries.get(opname, 0)

cinderx/PythonLib/cinderx/compiler/pycodegen.py

@@ -2688,6 +2688,12 @@ def _visitSequenceLoad(
     ) -> None:
         raise NotImplementedError()
 
+    def emit_load_assertion_error(self, loc: AST | SrcLocation | None = None) -> None:
+        if loc:
+            self.graph.emit_with_loc("LOAD_ASSERTION_ERROR", 0, loc)
+        else:
+            self.emit("LOAD_ASSERTION_ERROR")
+
     def visitAssert(self, node: ast.Assert) -> None:
         raise NotImplementedError()
 
@@ -2809,7 +2815,7 @@ def visitAssert(self, node: ast.Assert) -> None:
             end = self.newBlock()
             self.compileJumpIf(node.test, end, True)
 
-            self.emit("LOAD_ASSERTION_ERROR")
+            self.emit_load_assertion_error()
             if node.msg:
                 self.visit(node.msg)
                 self.emit_call_one_arg()
@@ -3867,7 +3873,7 @@ def visitAssert(self, node: ast.Assert) -> None:
             end = self.newBlock()
             self.compileJumpIf(node.test, end, True)
 
-            self.graph.emit_with_loc("LOAD_ASSERTION_ERROR", 0, node)
+            self.emit_load_assertion_error(node)
             if node.msg:
                 self.visit(node.msg)
                 self.set_pos(node)
@@ -5935,6 +5941,12 @@ def optimize_tree(
     def emit_binary_subscr(self) -> None:
         self.emit("BINARY_OP", self.find_op_idx("NB_SUBSCR"))
 
+    def emit_load_assertion_error(self, loc: AST | SrcLocation | None = None) -> None:
+        if loc:
+            self.graph.emit_with_loc("LOAD_COMMON_CONSTANT", AssertionError, loc)
+        else:
+            self.emit("LOAD_COMMON_CONSTANT", AssertionError)
+
     def emit_kwonlydefaults(self, node: FuncOrLambda) -> bool:
         default_count = 0
         for kwonly, default in zip(node.args.kwonlyargs, node.args.kw_defaults):