Remove unused type error suppressions - cinderx

Summary:
This diff was automatically generated by the Pyre per-target upgrade tool.

It removes `# pyre-fixme` or `pyrefly: ignore` comments that are no longer needed because the underlying type errors have been resolved.
Note that it will also aim to ensure type checking runs cleanly, and will add suppressions to existing type errors.

#pyreupgrade

Reviewed By: yoney

Differential Revision: D116323652

fbshipit-source-id: 16775a8bc83c1ef848623099f1596611af30e8a6

Author: maggiemoss

cinderx/PythonLib/cinderx/__init__.py

@@ -250,7 +250,6 @@ async def _async_compute(self) -> _T:
 
                 self.state = _AsyncLazyValueState.Done
 
-                # pyre-fixme[1001]: Awaitable assigned to `value` is never awaited.
                 for value in futures:
                     if not value.done():
                         value.set_result(self.res)
@@ -263,7 +262,6 @@ async def _async_compute(self) -> _T:
                 return res
 
             except (Exception, asyncio.CancelledError) as e:
-                # pyre-fixme[1001]: Awaitable assigned to `value` is never awaited.
                 for value in futures:
                     if not value.done():
                         value.set_exception(e)

cinderx/PythonLib/cinderx/_asyncio.py

@@ -88,7 +88,6 @@ async def _async_compute(self) -> _T:
 
                 self.state = _AsyncLazyValueState.Done
 
-                # pyre-ignore[1001]: Pyre is worried about how we're accessing futures
                 # without awaiting them.
                 for value in futures:
                     if not value.done():
@@ -102,7 +101,6 @@ async def _async_compute(self) -> _T:
                 return res
 
             except (Exception, CancelledError) as e:
-                # pyre-ignore[1001]: Pyre is worried about how we're accessing futures
                 # without awaiting them.
                 for value in futures:
                     if not value.done():

cinderx/PythonLib/cinderx/compiler/__init__.py

@@ -47,8 +47,6 @@ def get_disassembly_as_string(co: object, recurse: bool = False) -> str:
         dis.dis(co, file=s)
         return s.getvalue()
 
-    # pyre-fixme[21]: Could not find name `Formatter` in `dis` (stubbed).
-    # pyre-fixme[21]: Could not find name `_get_code_object` in `dis` (stubbed).
     from dis import _get_code_object, Bytecode, Formatter
 
     formatter = Formatter(file=s, offset_width=3)

cinderx/PythonLib/cinderx/compiler/dis_stable.py

@@ -74,7 +74,6 @@ def _disassemble_bytes(
     # Omit the line number column entirely if we have no line number info
     show_lineno = linestarts is not None
     if show_lineno:
-        # pyre-fixme [16]: `Optional` has no attribute `values`.
         maxlineno = max(linestarts.values()) + line_offset
         if maxlineno >= 1000:
             lineno_width = len(str(maxlineno))

cinderx/PythonLib/cinderx/compiler/flow_graph_optimizer.py

@@ -360,7 +360,6 @@ def opt_return_value(
     ) -> int | None:
         block.insts = block.insts[: instr_index + 1]
 
-    # pyrefly: ignore [bad-assignment]
     handlers: dict[str, Handler] = {
         # pyrefly: ignore [bad-assignment]
         "JUMP_IF_FALSE_OR_POP": opt_jump_if_false_or_pop,
@@ -1097,7 +1096,6 @@ def optimize_call_intrinsic_1(
         block: Block,
     ) -> int | None:
         assert isinstance(self, FlowGraphOptimizer314)
-        # pyre-fixme[16]: Module `opcodes` has no attribute `INTRINSIC_1`.
         intrins = INTRINSIC_1[instr.ioparg]
         if intrins == "INTRINSIC_LIST_TO_TUPLE":
             if next_instr is not None and next_instr.opname == "GET_ITER":

cinderx/PythonLib/cinderx/compiler/opcodes.py

@@ -50,11 +50,8 @@
         hasjabs,
         STATIC_CONST_OPCODES if sys.version_info >= (3, 14) else hasconst,
         hasarg,
-        # pyre-fixme[16]: Module `opcode` has no attribute `_cache_format`.
         _cache_format,
-        # pyre-fixme[16]: Module `opcode` has no attribute `_specializations`.
         _specializations,
-        # pyre-fixme[16]: Module `opcode` has no attribute `_inline_cache_entries`.
         _inline_cache_entries,
     )
     if sys.version_info >= (3, 14):
@@ -254,9 +251,6 @@
 )
 
 if sys.version_info >= (3, 12):
-    # pyre-fixme[21]: Could not find name `_intrinsic_1_descs` in `opcode` (stubbed).
-    # pyre-fixme[21]: Could not find name `_intrinsic_2_descs` in `opcode` (stubbed).
-    # pyre-fixme[21]: Could not find name `_nb_ops` in `opcode` (stubbed).
     from opcode import (
         # pyrefly: ignore [missing-module-attribute]
         _intrinsic_1_descs as INTRINSIC_1,
@@ -972,7 +966,6 @@ def _load_mapping_arg_effect(oparg: int, _jmp: int = 0) -> int:
 
 
 def find_op_idx(opname: str) -> int:
-    # pyre-fixme[16]: Module `opcode` has no attribute `_nb_ops`.
     for i, (name, _symbol) in enumerate(NB_OPS):
         if name == opname:
             return i

cinderx/PythonLib/cinderx/compiler/optimizer.py

@@ -33,7 +33,6 @@ class PyLimits:
     ast.NotIn: ast.In,
 }
 
-# pyrefly: ignore [bad-assignment]
 BIN_OPS: Mapping[type[ast.operator], Callable[[object, object], object]] = {
     # pyrefly: ignore [bad-assignment]
     ast.Add: operator.add,
@@ -240,7 +239,7 @@ def _visitIter(self, node: ast.expr) -> ast.expr:
             # pyre-ignore[6]: Can't type walk_list fully yet.
             res = self.makeConstTuple(elts)
             if res is not None:
-                # pyrefly: ignore [bad-argument-type, no-matching-overload]
+                # pyrefly: ignore [bad-argument-type]
                 return copy_location(Constant(frozenset(res.value)), node)
 
             return self.update_node(node, elts=elts)
@@ -534,9 +533,7 @@ def fold_const_match_patterns(self, node: ast.expr) -> ast.expr:
                 node = self.update_node(
                     node, left=self.fold_const_match_patterns(node.left)
                 )
-                # pyrefly: ignore [missing-attribute]
                 if isinstance(node.left, ast.Constant):
-                    # pyrefly: ignore [bad-argument-type]
                     return super().visitBinOp(node)
 
         return node

cinderx/PythonLib/cinderx/compiler/pyassem.py

@@ -1010,7 +1010,6 @@ def _convert_DEREF(self, arg: object) -> int:
         return self.closure.get_index(arg)
 
     # similarly for other opcodes...
-    # pyrefly: ignore [bad-assignment]
     _converters: dict[str, Callable[[PyFlowGraph, object], int]] = {
         # pyrefly: ignore [bad-assignment]
         "LOAD_CLASS": _convert_LOAD_CONST,
@@ -1289,11 +1288,9 @@ def duplicate_exits_without_lineno(self) -> None:
                     target.num_predecessors -= 1
                     new_target.num_predecessors = 1
                     target.insert_next(new_target)
-                    # pyrefly: ignore [missing-attribute]
                     append_after.setdefault(target, []).append(new_target)
         for after, to_append in append_after.items():
             idx = self.ordered_blocks.index(after) + 1
-            # pyrefly: ignore [no-matching-overload]
             self.ordered_blocks[idx:idx] = reversed(to_append)
 
         for block in self.ordered_blocks:
@@ -2516,7 +2513,7 @@ def _convert_compare_op(self: PyFlowGraph, arg: object) -> int:
     _converters: dict[str, Callable[[PyFlowGraph, object], int]] = {
         **PyFlowGraph312._converters,
         "LOAD_COMMON_CONSTANT": lambda self, val: PyFlowGraph314._constant_idx[val],
-        # pyrefly: ignore [bad-index, bad-typed-dict-key]
+        # pyrefly: ignore [bad-index]
         "LOAD_SPECIAL": lambda self, val: PyFlowGraph314._load_special_idx[val],
         "COMPARE_OP": _convert_compare_op,
     }

cinderx/PythonLib/cinderx/compiler/pycodegen.py

@@ -3248,11 +3248,9 @@ def visitSubscript(self, node: ast.Subscript, aug_flag: bool = False) -> None:
             assert 0
 
     def emit_call_intrinsic_1(self, oparg: str) -> None:
-        # pyre-fixme[16]: Module `opcodes` has no attribute `INTRINSIC_1`.
         self.emit("CALL_INTRINSIC_1", INTRINSIC_1.index(oparg))
 
     def emit_call_intrinsic_2(self, oparg: str) -> None:
-        # pyre-fixme[16]: Module `opcodes` has no attribute `INTRINSIC_2`.
         self.emit("CALL_INTRINSIC_2", INTRINSIC_2.index(oparg))
 
     def emit_import_star(self) -> None:
@@ -6464,7 +6462,6 @@ def visitImportFrom(self, node: ast.ImportFrom) -> None:
             name = alias.name
             asname = alias.asname
             if name == "*":
-                # pyre-fixme[16] This field does not appear to be used.
                 self.namespace = 0
                 self.emit_import_star()
                 # There can only be one name w/ from ... import *

cinderx/PythonLib/cinderx/compiler/pysourceloader.py

@@ -20,7 +20,6 @@
 from .pycodegen import compile_code
 
 
-# pyre-fixme[13]: path inherited but not initialized
 class PySourceFileLoader(SourceFileLoader):
     # pyrefly: ignore [bad-override]
     def source_to_code(