Skip to content

Commit 2c5d704

Browse files
alexmalyshevmeta-codesync[bot]
authored andcommitted
Only set -fvisibility-inlines-hidden for C++ code (#48)
Summary: GCC will warn when its set for C code and it gets noisy. Pull Request resolved: #48 Reviewed By: yoney Differential Revision: D103699796 Pulled By: alexmalyshev fbshipit-source-id: ae2c1000eb05a3aeaf39124a1f084190669fa4c2
1 parent ec317cd commit 2c5d704

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

CMakeLists.txt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,11 @@ set(CMAKE_CXX_STANDARD 20)
3939
set(CMAKE_CXX_STANDARD_REQUIRED ON)
4040

4141
if (WINDOWS)
42-
set(SHARED_FLAGS "-DPy_BUILD_CORE -DPy_BUILD_CORE_MODULE")
42+
set(SHARED_FLAGS "-DPy_BUILD_CORE -DPy_BUILD_CORE_MODULE")
43+
set(CXX_FLAGS "")
4344
else()
44-
set(SHARED_FLAGS "-DPy_BUILD_CORE -DPy_BUILD_CORE_MODULE -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -Wno-attributes -Wno-c99-designator -Wno-c++11-narrowing -Wno-cast-function-type -Wno-cast-function-type-mismatch -Wno-deprecated-declarations -Wno-missing-field-initializers -Wno-null-pointer-subtraction -Wno-parentheses -Wno-sign-compare -Wno-unknown-pragmas -Wno-unused-function -Wno-unused-parameter")
45+
set(SHARED_FLAGS "-DPy_BUILD_CORE -DPy_BUILD_CORE_MODULE -fPIC -fvisibility=hidden -Wall -Wextra -Wno-attributes -Wno-c99-designator -Wno-c++11-narrowing -Wno-cast-function-type -Wno-cast-function-type-mismatch -Wno-deprecated-declarations -Wno-missing-field-initializers -Wno-null-pointer-subtraction -Wno-parentheses -Wno-sign-compare -Wno-unknown-pragmas -Wno-unused-function -Wno-unused-parameter")
46+
set(CXX_FLAGS "-fvisibility-inlines-hidden")
4547
endif()
4648

4749
macro(set_flag VAR)
@@ -67,7 +69,7 @@ set_flag(ENABLE_USDT)
6769
set_flag(ENABLE_ZLIB)
6870

6971
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${SHARED_FLAGS}")
70-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${SHARED_FLAGS}")
72+
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_FLAGS} ${SHARED_FLAGS}")
7173

7274
##############################################################################
7375
# Apply LTO (Link-Time Optimization) if enabled

0 commit comments

Comments
 (0)