Static lib handling for glog and gflags

Summary:
X-link: facebook/folly#2587

Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation.

Reviewed By: bigfootjon

Differential Revision: D93644456

fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501

Author: afrind

build/fbcode_builder/manifests/gflags

@@ -10,11 +10,16 @@ builder = cmake
 subdir = gflags-2.2.2
 
 [cmake.defines]
-BUILD_SHARED_LIBS = ON
 BUILD_STATIC_LIBS = ON
 #BUILD_gflags_nothreads_LIB = OFF
 BUILD_gflags_LIB = ON
 
+[cmake.defines.os=windows]
+BUILD_SHARED_LIBS = ON
+
+[cmake.defines.shared_libs=on]
+BUILD_SHARED_LIBS = ON
+
 [homebrew]
 gflags
 

build/fbcode_builder/manifests/glog

@@ -13,10 +13,15 @@ subdir = glog-0.5.0
 gflags
 
 [cmake.defines]
-BUILD_SHARED_LIBS=ON
 BUILD_TESTING=NO
 WITH_PKGCONFIG=ON
 
+[cmake.defines.os=windows]
+BUILD_SHARED_LIBS=ON
+
+[cmake.defines.shared_libs=on]
+BUILD_SHARED_LIBS=ON
+
 [cmake.defines.os=freebsd]
 HAVE_TR1_UNORDERED_MAP=OFF
 HAVE_TR1_UNORDERED_SET=OFF