Support new LOAD_SMALL_INT opcode

Summary: doeswhatitsaysonthetin

Reviewed By: alexmalyshev

Differential Revision: D79689525

fbshipit-source-id: a8e20c5fcaadcae0865791d8c286e9174839a22f

Author: jbower-fb

cinderx/Common/opcode_stubs.h

@@ -4,11 +4,12 @@
 
 #include "cinderx/python.h"
 
-// Define all bytecodes that appeared or were removed between 3.10 and 3.12.
-// Bytecodes that don't match the Python version being used for the current
-// build will be intentionally defined to out-of-range values (i.e. >255) so as
-// to not be reachable by the interpreter, or any utilities that read or write
-// to code objects.
+// Define all bytecodes that appeared or were removed from <lowest version of
+// Python we support> and <highest version of Python we support>. Bytecodes that
+// don't match the Python version being used for the current build will be
+// intentionally defined to out-of-range values (i.e. >255) so as to not be
+// reachable by the interpreter, or any utilities that read or write to code
+// objects.
 //
 // Having them defined across all builds means there can be less Python version
 // checks in the compiler.
@@ -69,6 +70,7 @@
   X(LOAD_FROM_DICT_OR_DEREF)           \
   X(LOAD_FROM_DICT_OR_GLOBALS)         \
   X(LOAD_LOCALS)                       \
+  X(LOAD_SMALL_INT)                    \
   X(LOAD_SUPER_ATTR)                   \
   X(MAKE_CELL)                         \
   X(POP_JUMP_IF_NONE)                  \
@@ -178,6 +180,7 @@ enum {
   X(LOAD_METHOD_TYPE_METHODLIKE)   \
   X(LOAD_METHOD_UNCACHABLE)        \
   X(LOAD_METHOD_UNSHADOWED_METHOD) \
+  X(LOAD_SMALL_INT)                \
   X(MAKE_OPNAME)                   \
   X(ROT_FOUR)                      \
   X(ROT_N)                         \

cinderx/Jit/hir/builder.cpp

@@ -6,6 +6,7 @@
 
 #if PY_VERSION_HEX >= 0x030C0000
 #include "internal/pycore_intrinsics.h"
+#include "internal/pycore_long.h"
 #include "internal/pycore_runtime.h"
 #endif
 
@@ -156,6 +157,7 @@ bool isSupportedOpcode(int opcode) {
     case LOAD_METHOD:
     case LOAD_METHOD_STATIC:
     case LOAD_METHOD_SUPER:
+    case LOAD_SMALL_INT:
     case LOAD_SUPER_ATTR:
     case LOAD_TYPE:
     case MAKE_CELL:
@@ -1026,6 +1028,10 @@ void HIRBuilder::translate(
           emitLoadLocal(tc, bc_instr);
           break;
         }
+        case LOAD_SMALL_INT: {
+          emitLoadSmallInt(tc, bc_instr);
+          break;
+        }
         case LOAD_TYPE: {
           emitLoadType(tc, bc_instr);
           break;
@@ -2922,6 +2928,23 @@ void HIRBuilder::emitLoadLocal(
   tc.frame.stack.push(var);
 }
 
+void HIRBuilder::emitLoadSmallInt(
+    [[maybe_unused]] TranslationContext& tc,
+    [[maybe_unused]] const jit::BytecodeInstruction& bc_instr) {
+#if PY_VERSION_HEX >= 0x030E0000
+  Register* tmp = temps_.AllocateStack();
+  JIT_CHECK(
+      bc_instr.oparg() < _PY_NSMALLPOSINTS, "LOAD_SMALL_INT out of range");
+  tc.emit<LoadConst>(
+      tmp,
+      Type::fromObject(reinterpret_cast<PyObject*>(
+          &_PyLong_SMALL_INTS[_PY_NSMALLNEGINTS + bc_instr.oparg()])));
+  tc.frame.stack.push(tmp);
+#else
+  JIT_ABORT("LOAD_SMALL_INT not supported on this Python version");
+#endif
+}
+
 void HIRBuilder::emitStoreLocal(
     TranslationContext& tc,
     const jit::BytecodeInstruction& bc_instr) {

cinderx/Jit/hir/builder.h

@@ -298,6 +298,9 @@ class HIRBuilder {
   void emitTpAlloc(
       TranslationContext& tc,
       const jit::BytecodeInstruction& bc_instr);
+  void emitLoadSmallInt(
+      TranslationContext& tc,
+      const jit::BytecodeInstruction& bc_instr);
   void emitStoreLocal(
       TranslationContext& tc,
       const jit::BytecodeInstruction& bc_instr);