Skip to content

Commit 418d36c

Browse files
DinoVmeta-codesync[bot]
authored andcommitted
Back out "Revert D93657219: [Cinderx][ARM64] Need to set output type even if input isn't small"
Summary: Reverting the revert - this is an ARM specific commit which wouldn't cause IG issues. If we have a small output type the input can end up being big (e.g. a 64-bit "1"). So this needs to apply even in that case. Original commit changeset: 0601642fbbd3 Original Phabricator Diff: D93657219 Reviewed By: yoney Differential Revision: D93753151 fbshipit-source-id: 752c41d0d8cc4208514d188c5b294e6dd14518ca
1 parent 8eaba29 commit 418d36c

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

cinderx/Jit/lir/postalloc.cpp

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -706,13 +706,11 @@ RewriteResult rewriteSubWordRegMoves(instr_iter_t instr_iter) {
706706
return kUnchanged;
707707
}
708708

709-
size = in->dataType();
710-
if (size != OperandBase::k8bit && size != OperandBase::k16bit) {
711-
return kUnchanged;
712-
}
713-
714709
out->setDataType(OperandBase::k32bit);
715-
static_cast<Operand*>(in)->setDataType(OperandBase::k32bit);
710+
if (in->dataType() == OperandBase::k8bit ||
711+
in->dataType() == OperandBase::k16bit) {
712+
static_cast<Operand*>(in)->setDataType(OperandBase::k32bit);
713+
}
716714
return kChanged;
717715
}
718716
#endif

0 commit comments

Comments
 (0)