Skip to content

Commit 4bf6a30

Browse files
r-barnesmeta-codesync[bot]
authored andcommitted
Fix tautological-compare in cinderx/ParallelGC/parallel_gc.c +1
Summary: LLVM has a warning `-Wtautological-compare` which gets triggered when overlapping comparisons create a statement that is always true or always false. Such a comparison occurred in this code and, here, I try to fix it. Please review carefully! - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: alexmalyshev Differential Revision: D92525751 fbshipit-source-id: da4b234f8bc2ce1677c1a84694d084a13c90e6a8
1 parent 0dfa2fd commit 4bf6a30

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

cinderx/ParallelGC/parallel_gc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ static void validate_list(PyGC_Head* head, enum flagstates flags) {
358358
next_value = NEXT_MASK_UNREACHABLE;
359359
break;
360360
default:
361-
assert(!"bad internal flags argument");
361+
assert(0 && "bad internal flags argument");
362362
}
363363
PyGC_Head* prev = head;
364364
PyGC_Head* gc = GC_NEXT(head);

0 commit comments

Comments
 (0)