ThreadedRef

Summary: Fixes up some usages of `Ref` to use `ThreadedRef`. I'm not actually sure how we are getting away with this today, but somehow I started hitting this elsewhere in this stack. We are clearly using these in multi-threaded compile (hence the serialization guards!) but we can't use `Ref` on 3.12+ because it's stored in interpreter state and we don't have access to it in multi-threaded compile. So this just moves them over to our ThreadedRef helper.

Reviewed By: alexmalyshev

Differential Revision: D92781351

fbshipit-source-id: 9cddbce620283057a35101420e8dad2f2b5d7cd5

Author: DinoV

cinderx/Jit/hir/hir.cpp

@@ -1195,7 +1195,7 @@ TypedArgument::TypedArgument(
       exact(exact),
       jit_type(jit_type) {
   ThreadedCompileSerialize guard;
-  this->pytype = Ref<PyTypeObject>::create(pytype);
+  this->pytype = ThreadedRef<PyTypeObject>::create(pytype);
   thread_safe_flags = pytype->tp_flags & kThreadSafeFlagsMask;
 }
 
@@ -1211,7 +1211,7 @@ TypedArgument::TypedArgument(const TypedArgument& other)
       jit_type(other.jit_type),
       thread_safe_flags(other.thread_safe_flags) {
   ThreadedCompileSerialize guard;
-  pytype = Ref<PyTypeObject>::create(other.pytype);
+  pytype = ThreadedRef<PyTypeObject>::create(other.pytype);
 }
 
 TypedArgument& TypedArgument::operator=(const TypedArgument& other) {

cinderx/Jit/hir/hir.h

@@ -4025,7 +4025,7 @@ struct TypedArgument {
   unsigned long threadSafeTpFlags() const;
 
   long locals_idx;
-  Ref<PyTypeObject> pytype;
+  ThreadedRef<PyTypeObject> pytype;
   int optional;
   int exact;
   Type jit_type;

cinderx/Jit/type_deopt_patchers.h

@@ -3,6 +3,7 @@
 
 #include "cinderx/Common/ref.h"
 #include "cinderx/Jit/code_patcher.h"
+#include "cinderx/Jit/threaded_compile.h"
 
 namespace jit {
 
@@ -41,8 +42,8 @@ class TypeAttrDeoptPatcher : public TypeDeoptPatcher {
  private:
   void onPatch() override;
 
-  Ref<PyUnicodeObject> attr_name_;
-  Ref<> target_object_;
+  ThreadedRef<PyUnicodeObject> attr_name_;
+  ThreadedRef<> target_object_;
 };
 
 class SplitDictDeoptPatcher : public TypeDeoptPatcher {
@@ -57,7 +58,7 @@ class SplitDictDeoptPatcher : public TypeDeoptPatcher {
  private:
   void onPatch() override;
 
-  Ref<PyUnicodeObject> attr_name_;
+  ThreadedRef<PyUnicodeObject> attr_name_;
 
   // We don't need to hold a strong reference to keys_ like we do for
   // attr_name_ because calls to PyTypeModified() happen before the old keys