Skip to content

Commit 5f4ce73

Browse files
jbower-fbmeta-codesync[bot]
authored andcommitted
Make all HIR .txt tests not skip and automatically update their expected output
Summary: Apparently we just skip if there isn't expected output for a new version of Python. To fix this I altered the test loader so it would output failed results (rather than skips) for tests with missing expected output for the current Python version. This way we can use the existing `update_hir_expected.py` script. As there are a small number of tests which we do actually want to skip in later Python versions I've added a new `--- Skip ---` directive which can be placed after any `--- Expected X.Y ---` sections to prevent the test being flagged as failed in future Python versions. Reviewed By: DinoV Differential Revision: D86166766 fbshipit-source-id: 3d912203c9de1e3cbf51b151197164da197506e9
1 parent 37c4527 commit 5f4ce73

23 files changed

Lines changed: 9387 additions & 483 deletions

cinderx/RuntimeTests/fixtures.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ class RuntimeTest : public ::testing::Test {
219219
Ref<>::steal(PyUnicode_FromString(JIT_TEST_MOD_NAME)))) {
220220
return Ref<>(nullptr);
221221
}
222-
auto args = Ref<>::steal(PyTuple_New(2));
222+
auto args = Ref<>::steal(PyTuple_New(1));
223223
if (args == nullptr) {
224224
return args;
225225
}

0 commit comments

Comments
 (0)