Skip to content

Commit 607e15b

Browse files
alexmalyshevmeta-codesync[bot]
authored andcommitted
Fix typo in AsyncLazyValueState::cancalledError -> cancelledError
Summary: The method name was misspelled as "cancalledError" (transposed 'a' and 'l') while the member variable it returns (cancelled_error_) and the Python class it wraps (asyncio.CancelledError) are both correctly spelled. Reviewed By: yoney Differential Revision: D94926828 fbshipit-source-id: c284479a098b0341bd91ef9f73d0d0db8791188b
1 parent 8a9b437 commit 607e15b

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

cinderx/async_lazy_value.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ BorrowedRef<> AsyncLazyValueState::asyncioFutureBlocking() {
123123
return asyncio_future_blocking_;
124124
}
125125

126-
BorrowedRef<PyTypeObject> AsyncLazyValueState::cancalledError() {
126+
BorrowedRef<PyTypeObject> AsyncLazyValueState::cancelledError() {
127127
if (cancelled_error_ != nullptr) {
128128
return cancelled_error_;
129129
}
@@ -488,7 +488,7 @@ static int AsyncLazyValue_set_result(AsyncLazyValueObj* self, PyObject* res) {
488488

489489
static int AsyncLazyValue_set_error(AsyncLazyValueObj* self, PyObject* exc) {
490490
int ok;
491-
if (PyObject_IsInstance(exc, get_state()->cancalledError())) {
491+
if (PyObject_IsInstance(exc, get_state()->cancelledError())) {
492492
ok = notify_futures(self->alv_futures, future_cancel_impl, exc);
493493
} else {
494494
ok = notify_futures(

cinderx/async_lazy_value.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ class AsyncLazyValueState : public IAsyncLazyValueState {
8484
}
8585

8686
BorrowedRef<> asyncioFutureBlocking();
87-
BorrowedRef<PyTypeObject> cancalledError();
87+
BorrowedRef<PyTypeObject> cancelledError();
8888

8989
BorrowedRef<PyGetSetDescrObject> futureSourceTraceback();
9090

0 commit comments

Comments
 (0)