Skip to content

Commit 7a0014c

Browse files
DinoVfacebook-github-bot
authored andcommitted
Disable test.test_perf_profiler on 3.14
Summary: This test currently fails with PEP 523 in place because our frame evaluation API conflicts with the perf trampoline evaluation API. Reviewed By: alexmalyshev Differential Revision: D79378552 fbshipit-source-id: ef987cf0ba320a6e07d3e566b487bb209cb94366
1 parent 3e80dc7 commit 7a0014c

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# TASK(T233029400): These don't pass because we use the PEP-523 evaluator
2+
3+
test.test_perf_profiler.*

cinderx/TestScripts/cinder_test_runner312.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,11 @@ def manage_worker(
284284
def _computeSkipTests(huntrleaks, use_rr=False) -> Tuple[Set[str], Set[str]]:
285285
skip_list_files = ["devserver_skip_tests.txt", "cinder_skip_test.txt"]
286286

287+
version = "".join(str(v) for v in sys.version_info[:2])
288+
versioned_file = f"cinder_skip_test_{version}.txt"
289+
if os.path.exists(os.path.join(os.path.dirname(__file__), versioned_file)):
290+
skip_list_files.append(versioned_file)
291+
287292
if support.check_sanitizer(address=True):
288293
skip_list_files.append("asan_skip_tests.txt")
289294

0 commit comments

Comments
 (0)