Skip to content

Commit 7b49246

Browse files
alexmalyshevfacebook-github-bot
authored andcommitted
Change PYTHONJITDISABLEHUGEPAGES to PYTHONJITHUGEPAGES
Summary: Now you'll be able to do =0 or =1 to control whether it should be enabled or disabled, rather than just disabling it. Nothing actually uses this today, but I've updated the references to it in IG Django. Reviewed By: czardoz Differential Revision: D79741469 fbshipit-source-id: 9e1f10c20f5e121cede841960bbd3426ed5c3862
1 parent b0bf9b1 commit 7b49246

3 files changed

Lines changed: 16 additions & 8 deletions

File tree

cinderx/Jit/pyjit.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -529,10 +529,10 @@ FlagProcessor initFlagProcessor() {
529529
"Dump JIT runtime stats at shutdown");
530530

531531
flag_processor.addOption(
532-
"jit-disable-huge-pages",
533-
"PYTHONJITDISABLEHUGEPAGES",
534-
[](const std::string&) { getMutableConfig().use_huge_pages = false; },
535-
"disable huge page support");
532+
"jit-huge-pages",
533+
"PYTHONJITHUGEPAGES",
534+
getMutableConfig().use_huge_pages,
535+
"Enable or disable huge pages for compiled functions");
536536

537537
flag_processor.addOption(
538538
"jit-enable-jit-list-wildcards",

cinderx/PythonLib/test_cinderx/test_cinderjit.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1657,7 +1657,7 @@ def onek_asserts(actual_stdout):
16571657
run_test(zero_asserts, ["-X", "jit-max-code-size=0"])
16581658
run_test(
16591659
zero_asserts,
1660-
["-X", "jit-max-code-size=0", "-X", "jit-disable-huge-pages"],
1660+
["-X", "jit-max-code-size=0", "-X", "jit-huge-pages=0"],
16611661
)
16621662
run_test(
16631663
zero_asserts,
@@ -1675,7 +1675,7 @@ def onek_asserts(actual_stdout):
16751675
run_test(onek_asserts, ["-X", "jit-max-code-size=1024"])
16761676
run_test(
16771677
onek_asserts,
1678-
["-X", "jit-max-code-size=1024", "-X", "jit-disable-huge-pages"],
1678+
["-X", "jit-max-code-size=1024", "-X", "jit-huge-pages=0"],
16791679
)
16801680
run_test(
16811681
onek_asserts,

cinderx/RuntimeTests/cmdline_test.cpp

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,12 +247,20 @@ TEST_F(CmdLineTest, BasicFlags) {
247247

248248
ASSERT_EQ(
249249
try_flag_and_envvar_effect(
250-
L"jit-disable-huge-pages",
251-
"PYTHONJITDISABLEHUGEPAGES",
250+
L"jit-huge-pages=0",
251+
"PYTHONJITHUGEPAGES=0",
252252
[]() {},
253253
[]() { ASSERT_FALSE(getConfig().use_huge_pages); }),
254254
0);
255255

256+
ASSERT_EQ(
257+
try_flag_and_envvar_effect(
258+
L"jit-huge-pages=1",
259+
"PYTHONJITHUGEPAGES=1",
260+
[]() {},
261+
[]() { ASSERT_TRUE(getConfig().use_huge_pages); }),
262+
0);
263+
256264
ASSERT_EQ(
257265
try_flag_and_envvar_effect(
258266
L"jit-enable-jit-list-wildcards",

0 commit comments

Comments
 (0)