Separate RefcountInsertion to its own library

Summary: Continuing down the path of modularizing the optimization passes.

Reviewed By: martindemello

Differential Revision: D78897769

fbshipit-source-id: 4690a897a17b35456b2d86a6b98d82bd0e29c523

Author: alexmalyshev

Jit/compiler.cpp

@@ -10,6 +10,7 @@
 #include "cinderx/Jit/hir/optimization.h"
 #include "cinderx/Jit/hir/phi_elimination.h"
 #include "cinderx/Jit/hir/printer.h"
+#include "cinderx/Jit/hir/refcount_insertion.h"
 #include "cinderx/Jit/hir/ssa.h"
 #include "cinderx/Jit/jit_time_log.h"
 

Jit/hir/optimization.h

@@ -8,21 +8,6 @@
 
 namespace jit::hir {
 
-// Inserts incref/decref instructions.
-class RefcountInsertion : public Pass {
- public:
-  RefcountInsertion() : Pass("RefcountInsertion") {}
-
-  void Run(Function& irfunc) override;
-
-  static std::unique_ptr<RefcountInsertion> Factory() {
-    return std::make_unique<RefcountInsertion>();
-  }
-
- private:
-  DISALLOW_COPY_AND_ASSIGN(RefcountInsertion);
-};
-
 // Perform a mixed bag of strength-reduction optimizations: remove redundant
 // null checks, conversions, loads from compile-time constant containers, etc.
 //

Jit/hir/refcount_insertion.cpp

@@ -1,12 +1,13 @@
 // Copyright (c) Meta Platforms, Inc. and affiliates.
 
+#include "cinderx/Jit/hir/refcount_insertion.h"
+
 #include "cinderx/Common/log.h"
 #include "cinderx/Jit/bitvector.h"
 #include "cinderx/Jit/deopt.h"
 #include "cinderx/Jit/hir/analysis.h"
 #include "cinderx/Jit/hir/dead_code_elimination.h"
 #include "cinderx/Jit/hir/instr_effects.h"
-#include "cinderx/Jit/hir/optimization.h"
 #include "cinderx/Jit/hir/phi_elimination.h"
 #include "cinderx/Jit/hir/printer.h"
 

Jit/hir/refcount_insertion.h

@@ -0,0 +1,24 @@
+// Copyright (c) Meta Platforms, Inc. and affiliates.
+
+#pragma once
+
+#include "cinderx/Jit/hir/pass.h"
+
+namespace jit::hir {
+
+// Inserts incref/decref instructions.
+class RefcountInsertion : public Pass {
+ public:
+  RefcountInsertion() : Pass("RefcountInsertion") {}
+
+  void Run(Function& irfunc) override;
+
+  static std::unique_ptr<RefcountInsertion> Factory() {
+    return std::make_unique<RefcountInsertion>();
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(RefcountInsertion);
+};
+
+} // namespace jit::hir

RuntimeTests/hir_guard_test.cpp

@@ -2,9 +2,9 @@
 #include <gtest/gtest.h>
 
 #include "cinderx/Jit/hir/hir.h"
-#include "cinderx/Jit/hir/optimization.h"
 #include "cinderx/Jit/hir/parser.h"
 #include "cinderx/Jit/hir/printer.h"
+#include "cinderx/Jit/hir/refcount_insertion.h"
 #include "cinderx/Jit/hir/ssa.h"
 #include "cinderx/RuntimeTests/fixtures.h"
 

RuntimeTests/hir_test.cpp

@@ -7,10 +7,10 @@
 #include "cinderx/Jit/compiler.h"
 #include "cinderx/Jit/hir/builder.h"
 #include "cinderx/Jit/hir/hir.h"
-#include "cinderx/Jit/hir/optimization.h"
 #include "cinderx/Jit/hir/parser.h"
 #include "cinderx/Jit/hir/phi_elimination.h"
 #include "cinderx/Jit/hir/printer.h"
+#include "cinderx/Jit/hir/refcount_insertion.h"
 #include "cinderx/Jit/hir/ssa.h"
 #include "cinderx/RuntimeTests/fixtures.h"
 

RuntimeTests/main.cpp

@@ -11,6 +11,7 @@
 #include "cinderx/Jit/hir/dead_code_elimination.h"
 #include "cinderx/Jit/hir/optimization.h"
 #include "cinderx/Jit/hir/phi_elimination.h"
+#include "cinderx/Jit/hir/refcount_insertion.h"
 #include "cinderx/RuntimeTests/fixtures.h"
 #include "cinderx/RuntimeTests/testutil.h"