Remove redundant operator!= implementations

Summary: Remove `operator!=` implementations synthesized from `operator==` under C++20.

Reviewed By: mpage

Differential Revision: D116081154

fbshipit-source-id: 858ef1edb1ba065f95fb3acc8f94a702c4ab446b

Author: yoney

cinderx/Common/slab.h

@@ -46,10 +46,6 @@ class SlabIterator {
     return ptr_ == o.ptr_;
   }
 
-  bool operator!=(const SlabIterator& o) const {
-    return !operator==(o);
-  }
-
  private:
   char* ptr_{nullptr};
   size_t increment_{0};

cinderx/Common/slab_arena.h

@@ -41,7 +41,6 @@ class SlabArenaIterator {
   }
 
   bool operator==(const SlabArenaIterator& other) const = default;
-  bool operator!=(const SlabArenaIterator& other) const = default;
 
   T& operator*() {
     return *slab_iter_;

cinderx/Jit/bitvector.cpp

@@ -95,10 +95,6 @@ bool BitVector::operator==(const BitVector& rhs) const {
   return std::equal(cs.begin(), cs.end(), rhs.chunks().begin());
 }
 
-bool BitVector::operator!=(const BitVector& rhs) const {
-  return !(*this == rhs);
-}
-
 template <typename Op>
 BitVector BitVector::binaryOp(const BitVector& rhs, const Op& op) const {
   JIT_THROW_IF(

cinderx/Jit/bitvector.h

@@ -35,7 +35,6 @@ class BitVector {
   // analysis), we only support operations between two bit vectors with the same
   // width.
   bool operator==(const BitVector& rhs) const;
-  bool operator!=(const BitVector& rhs) const;
   BitVector operator&(const BitVector& rhs) const;
   BitVector operator|(const BitVector& rhs) const;
   BitVector operator-(const BitVector& rhs) const;

cinderx/Jit/bytecode.h

@@ -158,10 +158,6 @@ class BytecodeInstructionBlock {
       return bci_ == other.bci_;
     }
 
-    bool operator!=(const Iterator& other) const {
-      return !(*this == other);
-    }
-
    private:
     BytecodeInstruction bci_;
     BCIndex end_idx_;

cinderx/Jit/codegen/arch/phy_location.h

@@ -51,10 +51,6 @@ struct PhyLocationBase {
   constexpr bool operator==(const PhyLocationBase& rhs) const {
     return loc == rhs.loc;
   }
-
-  constexpr bool operator!=(const PhyLocationBase& rhs) const {
-    return loc != rhs.loc;
-  }
 };
 
 } // namespace cinderx::jit::codegen

cinderx/Jit/debug_info.h

@@ -104,7 +104,6 @@ class DebugInfo {
     }
 
     bool operator==(const LocNode& other) const = default;
-    bool operator!=(const LocNode& other) const = default;
   };
 
   static const uint16_t kNoCallerID = UINT16_MAX;

cinderx/Jit/hir/alias_class.h

@@ -70,9 +70,6 @@ class AliasClass {
   bool operator==(AliasClass other) const {
     return bits_ == other.bits_;
   }
-  bool operator!=(AliasClass other) const {
-    return !operator==(other);
-  }
 
   bool operator<=(AliasClass other) const {
     return (bits_ & other.bits_) == bits_;

cinderx/Jit/hir/frame_state.h

@@ -25,10 +25,6 @@ struct ExecutionBlock {
         (stack_level == other.stack_level);
   }
 
-  bool operator!=(const ExecutionBlock& other) const {
-    return !(*this == other);
-  }
-
   bool isTryBlock() const {
     return opcode == SETUP_FINALLY;
   }
@@ -61,7 +57,6 @@ struct FrameState {
   FrameState& operator=(const FrameState& other) = default;
 
   bool operator==(const FrameState& other) const = default;
-  bool operator!=(const FrameState& other) const = default;
 
   // If the function is inlined into another function, the depth at which it
   // is inlined (nested function calls may be inlined). Starts at 1. If the

cinderx/Jit/hir/refcount_insertion.cpp

@@ -278,9 +278,6 @@ class StateMap {
   bool operator==(const StateMap& other) const {
     return map_ == other.map_;
   }
-  bool operator!=(const StateMap& other) const {
-    return !operator==(other);
-  }
 
  private:
   map_t map_;