Skip to content

Commit 8457ba1

Browse files
DinoVfacebook-github-bot
authored andcommitted
Skip unit tests on 3.14
Summary: These tests will start failing on 3.14 when we enable it. But they're also currently disabled and failing on 3.12. This updates the expected results and marks them to be run on 3.12 but not 3.14 using a feature flag. Reviewed By: czardoz Differential Revision: D78598891 fbshipit-source-id: 9d53a7128c5b9650c4a513e277913597abc50a86
1 parent d2f3299 commit 8457ba1

17 files changed

Lines changed: 90 additions & 98 deletions

RuntimeTests/hir_frame_state_test.cpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -209,9 +209,9 @@ def test(fs):
209209
CurInstrOffset 24
210210
Locals<2> v0 v1
211211
}
212-
v8 = LoadConst<NoneType>
213-
v8 = RefineType<NoneType> v8
214-
Return<NoneType> v8
212+
v8 = LoadConst<ImmortalNoneType>
213+
v8 = RefineType<ImmortalNoneType> v8
214+
Return<ImmortalNoneType> v8
215215
}
216216
}
217217
)";
@@ -942,9 +942,9 @@ def test(x, y):
942942
Stack<1> v5
943943
}
944944
v0 = Assign v5
945-
v6 = LoadConst<NoneType>
946-
v6 = RefineType<NoneType> v6
947-
Return<NoneType> v6
945+
v6 = LoadConst<ImmortalNoneType>
946+
v6 = RefineType<ImmortalNoneType> v6
947+
Return<ImmortalNoneType> v6
948948
}
949949
}
950950
)";
@@ -1224,9 +1224,9 @@ def test(x, y):
12241224
CurInstrOffset 16
12251225
Locals<2> v0 v1
12261226
}
1227-
v5 = LoadConst<NoneType>
1228-
v5 = RefineType<NoneType> v5
1229-
Return<NoneType> v5
1227+
v5 = LoadConst<ImmortalNoneType>
1228+
v5 = RefineType<ImmortalNoneType> v5
1229+
Return<ImmortalNoneType> v5
12301230
}
12311231
}
12321232
)";
@@ -1322,9 +1322,9 @@ def test(x, y):
13221322
CurInstrOffset 12
13231323
Locals<2> v0 v1
13241324
}
1325-
v6 = LoadConst<NoneType>
1326-
v6 = RefineType<NoneType> v6
1327-
Return<NoneType> v6
1325+
v6 = LoadConst<ImmortalNoneType>
1326+
v6 = RefineType<ImmortalNoneType> v6
1327+
Return<ImmortalNoneType> v6
13281328
}
13291329
}
13301330
)";

RuntimeTests/hir_test.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -909,7 +909,7 @@ TEST_F(EdgeCaseTest, IgnoreUnreachableLoops) {
909909
Snapshot {
910910
CurInstrOffset 0
911911
}
912-
v1 = LoadConst<NoneType>
912+
v1 = LoadConst<ImmortalNoneType>
913913
Return v1
914914
}
915915
}
@@ -994,7 +994,7 @@ TEST_F(EdgeCaseTest, JumpBackwardNoInterrupt) {
994994
Snapshot {
995995
CurInstrOffset 0
996996
}
997-
v1 = LoadConst<NoneType>
997+
v1 = LoadConst<ImmortalNoneType>
998998
Return v1
999999
}
10001000
}
@@ -1498,7 +1498,7 @@ TEST_F(HIRBuildTest, MatchKeys) {
14981498
Stack<2> v0 v1
14991499
}
15001500
}
1501-
v4 = LoadConst<NoneType>
1501+
v4 = LoadConst<ImmortalNoneType>
15021502
v5 = PrimitiveCompare<Equal> v3 v4
15031503
CondBranch<1, 2> v5
15041504
}

RuntimeTests/hir_tests/all_passes_static_test.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,9 +193,8 @@ fun jittestmodule:test {
193193
bb 3 (preds 1) {
194194
UpdatePrevInstr<idx:35 line_no:-1>
195195
XDecref v34
196-
v53:NoneType = LoadConst<NoneType>
197-
Incref v53
198-
Return<NoneType> v53
196+
v53:ImmortalNoneType = LoadConst<ImmortalNoneType>
197+
Return<ImmortalNoneType> v53
199198
}
200199
}
201200
--- End ---

RuntimeTests/hir_tests/all_passes_test.txt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -510,9 +510,8 @@ fun jittestmodule:test {
510510
}
511511
UpdatePrevInstr<idx:20 line_no:3>
512512
Decref v15
513-
v21:NoneType = LoadConst<NoneType>
514-
Incref v21
515-
Return<NoneType> v21
513+
v21:ImmortalNoneType = LoadConst<ImmortalNoneType>
514+
Return<ImmortalNoneType> v21
516515
}
517516
}
518517
--- Test Name ---
@@ -659,7 +658,7 @@ fun jittestmodule:test {
659658
}
660659

661660
bb 9 (preds 8, 10) {
662-
v33:NoneType = LoadConst<NoneType>
661+
v33:ImmortalNoneType = LoadConst<ImmortalNoneType>
663662
Branch<1>
664663
}
665664

RuntimeTests/hir_tests/builtin_load_method_elimination_test.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,7 @@ fun jittestmodule:test {
571571

572572
bb 9 (preds 8, 10) {
573573
Snapshot
574-
v27:NoneType = LoadConst<NoneType>
574+
v27:ImmortalNoneType = LoadConst<ImmortalNoneType>
575575
Branch<1>
576576
}
577577

RuntimeTests/hir_tests/dead_code_elimination_test.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,8 +256,8 @@ fun jittestmodule:test {
256256
}
257257
}
258258
Snapshot
259-
v21:NoneType = LoadConst<NoneType>
260-
Return<NoneType> v21
259+
v21:ImmortalNoneType = LoadConst<ImmortalNoneType>
260+
Return<ImmortalNoneType> v21
261261
}
262262
}
263263
--- Test Name ---

RuntimeTests/hir_tests/dynamic_comparison_elimination_test.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,8 +261,8 @@ fun jittestmodule:test {
261261

262262
bb 2 (preds 6) {
263263
Snapshot
264-
v25:NoneType = LoadConst<NoneType>
265-
Return<NoneType> v25
264+
v25:ImmortalNoneType = LoadConst<ImmortalNoneType>
265+
Return<ImmortalNoneType> v25
266266
}
267267
}
268268
--- End ---

RuntimeTests/hir_tests/hir_builder_static_test.txt

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ fun jittestmodule:test {
199199

200200
bb 9 (preds 8, 10) {
201201
Snapshot
202-
v13 = LoadConst<NoneType>
202+
v13 = LoadConst<ImmortalNoneType>
203203
v2 = Assign v11
204204
v3 = Assign v13
205205
Branch<1>
@@ -369,9 +369,9 @@ fun jittestmodule:test {
369369
v5 = LoadField<x@16, OptObject, owned> v0
370370
StoreField<x@16> v0 v1 v5
371371
Snapshot
372-
v6 = LoadConst<NoneType>
373-
v6 = RefineType<NoneType> v6
374-
Return<NoneType> v6
372+
v6 = LoadConst<ImmortalNoneType>
373+
v6 = RefineType<ImmortalNoneType> v6
374+
Return<ImmortalNoneType> v6
375375
}
376376
}
377377
--- Test Name ---
@@ -643,7 +643,7 @@ fun jittestmodule:test {
643643

644644
bb 9 (preds 8, 10) {
645645
Snapshot
646-
v10 = LoadConst<NoneType>
646+
v10 = LoadConst<ImmortalNoneType>
647647
v1 = Assign v8
648648
v2 = Assign v10
649649
Branch<1>
@@ -1469,9 +1469,9 @@ fun jittestmodule:test {
14691469
}
14701470
}
14711471
Snapshot
1472-
v7 = LoadConst<NoneType>
1473-
v7 = RefineType<NoneType> v7
1474-
Return<NoneType> v7
1472+
v7 = LoadConst<ImmortalNoneType>
1473+
v7 = RefineType<ImmortalNoneType> v7
1474+
Return<ImmortalNoneType> v7
14751475
}
14761476
}
14771477
--- Test Name ---

RuntimeTests/hir_tests/refcount_insertion_static_test.txt

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,8 @@ fun jittestmodule:Test.__init__ {
4747
v13:CInt32[0] = LoadConst<CInt32[0]>
4848
v14:Nullptr = LoadConst<Nullptr>
4949
StoreField<x@16> v8 v13 v14
50-
v16:NoneType = LoadConst<NoneType>
51-
Incref v16
52-
Return<NoneType> v16
50+
v16:ImmortalNoneType = LoadConst<ImmortalNoneType>
51+
Return<ImmortalNoneType> v16
5352
}
5453
}
5554
--- Test Name ---
@@ -97,9 +96,8 @@ fun jittestmodule:Test.__init__ {
9796
v13:OptObject = LoadField<x@16, OptObject, owned> v7
9897
StoreField<x@16> v7 v12 v13
9998
XDecref v13
100-
v14:NoneType = LoadConst<NoneType>
101-
Incref v14
102-
Return<NoneType> v14
99+
v14:ImmortalNoneType = LoadConst<ImmortalNoneType>
100+
Return<ImmortalNoneType> v14
103101
}
104102
}
105103
--- End ---

RuntimeTests/hir_tests/refcount_insertion_test.txt

Lines changed: 18 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -665,9 +665,8 @@ fun jittestmodule:test {
665665
XDecref v40
666666
Decref v57
667667
Decref v62
668-
v59:NoneType = LoadConst<NoneType>
669-
Incref v59
670-
Return<NoneType> v59
668+
v59:ImmortalNoneType = LoadConst<ImmortalNoneType>
669+
Return<ImmortalNoneType> v59
671670
}
672671
}
673672
--- Test Name ---
@@ -947,9 +946,8 @@ fun jittestmodule:test {
947946
}
948947
XDecref v52
949948
BatchDecref v69 v74 v75 v76
950-
v71:NoneType = LoadConst<NoneType>
951-
Incref v71
952-
Return<NoneType> v71
949+
v71:ImmortalNoneType = LoadConst<ImmortalNoneType>
950+
Return<ImmortalNoneType> v71
953951
}
954952
}
955953
--- Test Name ---
@@ -1198,9 +1196,8 @@ fun jittestmodule:test {
11981196
Decref v32
11991197
Decref v37
12001198
XDecref v38
1201-
v55:NoneType = LoadConst<NoneType>
1202-
Incref v55
1203-
Return<NoneType> v55
1199+
v55:ImmortalNoneType = LoadConst<ImmortalNoneType>
1200+
Return<ImmortalNoneType> v55
12041201
}
12051202
}
12061203
--- Test Name ---
@@ -1253,9 +1250,8 @@ fun jittestmodule:test {
12531250
Locals<2> v6 v7
12541251
}
12551252
}
1256-
v13:NoneType = LoadConst<NoneType>
1257-
Incref v13
1258-
Return<NoneType> v13
1253+
v13:ImmortalNoneType = LoadConst<ImmortalNoneType>
1254+
Return<ImmortalNoneType> v13
12591255
}
12601256
}
12611257
--- Test Name ---
@@ -1864,16 +1860,14 @@ fun jittestmodule:test {
18641860
}
18651861
Decref v39
18661862
Decref v46
1867-
v41:NoneType = LoadConst<NoneType>
1868-
Incref v41
1869-
Return<NoneType> v41
1863+
v41:ImmortalNoneType = LoadConst<ImmortalNoneType>
1864+
Return<ImmortalNoneType> v41
18701865
}
18711866

18721867
bb 6 (preds 4) {
18731868
XDecref v34
1874-
v43:NoneType = LoadConst<NoneType>
1875-
Incref v43
1876-
Return<NoneType> v43
1869+
v43:ImmortalNoneType = LoadConst<ImmortalNoneType>
1870+
Return<ImmortalNoneType> v43
18771871
}
18781872
}
18791873
--- Test Name ---
@@ -2088,8 +2082,7 @@ fun jittestmodule:test {
20882082
}
20892083

20902084
bb 3 (preds 2) {
2091-
v49:NoneType = LoadConst<NoneType>
2092-
Incref v49
2085+
v49:ImmortalNoneType = LoadConst<ImmortalNoneType>
20932086
Branch<4>
20942087
}
20952088

@@ -2101,11 +2094,11 @@ fun jittestmodule:test {
21012094
bb 4 (preds 3, 8) {
21022095
v52:Object = Phi<3, 8> v65 v22
21032096
v54:{DictExact|NoneType} = Phi<3, 8> v49 v65
2104-
v55:NoneType = LoadConst<NoneType>
2097+
v55:ImmortalNoneType = LoadConst<ImmortalNoneType>
21052098
v58:OptObject = LoadGlobalCached<1; "print">
21062099
v59:MortalObjectUser[builtin_function_or_method:print:0xdeadbeef] = GuardIs<0xdeadbeef> v58 {
21072100
Descr 'LOAD_GLOBAL: print'
2108-
LiveValues<6> b:v23 b:v39 o:v52 o:v54 b:v55 b:v58
2101+
LiveValues<6> b:v23 b:v39 o:v52 o:v54 unc:v55 b:v58
21092102
FrameState {
21102103
CurInstrOffset 64
21112104
Locals<4> v39 v52 v23 v54
@@ -2114,7 +2107,7 @@ fun jittestmodule:test {
21142107
Incref v39
21152108
Decref v52
21162109
v64:Object = VectorCall<1> v59 v39 {
2117-
LiveValues<5> b:v23 o:v39 o:v54 b:v55 b:v59
2110+
LiveValues<5> b:v23 o:v39 o:v54 unc:v55 b:v59
21182111
FrameState {
21192112
CurInstrOffset 80
21202113
Locals<4> v39 v55 v23 v54
@@ -2123,9 +2116,8 @@ fun jittestmodule:test {
21232116
Decref v39
21242117
Decref v54
21252118
Decref v64
2126-
v61:NoneType = LoadConst<NoneType>
2127-
Incref v61
2128-
Return<NoneType> v61
2119+
v61:ImmortalNoneType = LoadConst<ImmortalNoneType>
2120+
Return<ImmortalNoneType> v61
21292121
}
21302122
}
21312123
--- Test Name ---

0 commit comments

Comments
 (0)