Skip to content

Commit 8c80169

Browse files
r-barnesfacebook-github-bot
authored andcommitted
Fix argument comment in cinderx/RuntimeTests/bytecode_test.cpp +3
Summary: Argument comments ensure that the correct values are assigned to the correct arguments. This diff is a manual fix (assisted by the script in D78190897) of one or more argument comments in cinderx/RuntimeTests/bytecode_test.cpp. Once existing violations are drawn down we will make mismatches between argument comments and argument names an error. Reviewed By: dtolnay Differential Revision: D78191313 fbshipit-source-id: 568626d6abadb1d6577b5f100ab536f60db9c621
1 parent cd22931 commit 8c80169

3 files changed

Lines changed: 16 additions & 16 deletions

File tree

RuntimeTests/bytecode_test.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ TEST_F(BytecodeInstructionIteratorTest, ConsumesExtendedArgs) {
4141
auto empty_bytes = Ref<>::steal(PyBytes_FromString(""));
4242
auto code = Ref<PyCodeObject>::steal(PyUnstable_Code_New(
4343
/*argcount=*/0,
44-
/*kwargcount=*/0,
44+
/*kwonlyargcount=*/0,
4545
/*nlocals=*/0,
4646
/*stacksize=*/0,
4747
/*flags=*/0,
@@ -53,10 +53,10 @@ TEST_F(BytecodeInstructionIteratorTest, ConsumesExtendedArgs) {
5353
/*cellvars=*/empty_tuple,
5454
filename,
5555
funcname,
56-
/*qualname=*/funcname,
56+
/*_unused_qualname=*/funcname,
5757
/*firstlineno=*/0,
5858
/*linetable=*/empty_bytes,
59-
/*exceptiontable=*/empty_bytes));
59+
/*_unused_exceptiontable=*/empty_bytes));
6060
ASSERT_NE(code.get(), nullptr);
6161

6262
jit::BytecodeInstructionBlock bc_block{code};

RuntimeTests/gen_asm_test.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1343,7 +1343,7 @@ TEST_F(ASMGeneratorTest, GetLength) {
13431343
auto empty_string = Ref<>::steal(PyBytes_FromString(""));
13441344
auto code = Ref<PyCodeObject>::steal(PyUnstable_Code_New(
13451345
/*argcount=*/1,
1346-
/*kwargcount=*/0,
1346+
/*kwonlyargcount=*/0,
13471347
/*nlocals=*/1,
13481348
/*stacksize=*/0,
13491349
/*flags=*/0,
@@ -1355,10 +1355,10 @@ TEST_F(ASMGeneratorTest, GetLength) {
13551355
/*cellvars=*/empty_tuple,
13561356
filename,
13571357
funcname,
1358-
/*qualname=*/funcname,
1358+
/*_unused_qualname=*/funcname,
13591359
/*firstlineno=*/0,
13601360
/*linetable=*/empty_string,
1361-
/*exceptiontable=*/empty_string));
1361+
/*_unused_exceptiontable=*/empty_string));
13621362
ASSERT_NE(code.get(), nullptr);
13631363

13641364
auto func = Ref<PyFunctionObject>::steal(PyFunction_New(code, MakeGlobals()));

RuntimeTests/hir_test.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -554,10 +554,10 @@ class HIRBuildTest : public RuntimeTest {
554554
/*cellvars=*/empty_tuple,
555555
filename,
556556
funcname,
557-
/*qualname=*/funcname,
557+
/*_unused_qualname=*/funcname,
558558
/*firstlineno=*/0,
559559
/*linetable=*/empty_bytes,
560-
/*exceptiontable=*/empty_bytes));
560+
/*_unused_exceptiontable=*/empty_bytes));
561561
assert(code != nullptr);
562562

563563
auto func =
@@ -662,10 +662,10 @@ TEST_F(HIRBuildTest, LoadAssertionError) {
662662
/*cellvars=*/empty_tuple,
663663
filename,
664664
funcname,
665-
/*qualname=*/funcname,
665+
/*_unused_qualname=*/funcname,
666666
/*firstlineno=*/0,
667667
/*linetable=*/empty_bytes,
668-
/*exceptiontable=*/empty_bytes));
668+
/*_unused_exceptiontable=*/empty_bytes));
669669
ASSERT_NE(code.get(), nullptr);
670670

671671
auto func = Ref<PyFunctionObject>::steal(PyFunction_New(code, MakeGlobals()));
@@ -755,10 +755,10 @@ TEST_F(HIRBuildTest, SetUpdate) {
755755
/*cellvars=*/empty_tuple,
756756
filename,
757757
funcname,
758-
/*qualname=*/funcname,
758+
/*_unused_qualname=*/funcname,
759759
/*firstlineno=*/0,
760760
/*linetable=*/empty_bytes,
761-
/*exceptiontable=*/empty_bytes));
761+
/*_unused_exceptiontable=*/empty_bytes));
762762
ASSERT_NE(code.get(), nullptr);
763763

764764
auto func = Ref<PyFunctionObject>::steal(PyFunction_New(code, MakeGlobals()));
@@ -892,10 +892,10 @@ TEST_F(EdgeCaseTest, IgnoreUnreachableLoops) {
892892
/*cellvars=*/empty_tuple,
893893
filename,
894894
funcname,
895-
/*qualname=*/funcname,
895+
/*_unused_qualname=*/funcname,
896896
/*firstlineno=*/0,
897897
/*linetable=*/empty_bytes,
898-
/*exceptiontable=*/empty_bytes));
898+
/*_unused_exceptiontable=*/empty_bytes));
899899
ASSERT_NE(code.get(), nullptr);
900900

901901
auto func = Ref<PyFunctionObject>::steal(PyFunction_New(code, MakeGlobals()));
@@ -976,10 +976,10 @@ TEST_F(EdgeCaseTest, JumpBackwardNoInterrupt) {
976976
/*cellvars=*/empty_tuple,
977977
filename,
978978
funcname,
979-
/*qualname=*/funcname,
979+
/*_unused_qualname=*/funcname,
980980
/*firstlineno=*/0,
981981
/*linetable=*/empty_bytes,
982-
/*exceptiontable=*/empty_bytes));
982+
/*_unused_exceptiontable=*/empty_bytes));
983983
ASSERT_NE(code.get(), nullptr);
984984

985985
auto func = Ref<PyFunctionObject>::steal(PyFunction_New(code, MakeGlobals()));

0 commit comments

Comments
 (0)