Skip to content

Commit 92f1a2b

Browse files
alexmalyshevmeta-codesync[bot]
authored andcommitted
Disable clang-tidy warning on int to pointer conversions
Summary: This is a JIT, it does a lot of int to pointer conversions. Reviewed By: jbower-fb Differential Revision: D83767582 fbshipit-source-id: ae84d32bfffa93058ca5b8f5585f3fd346aac016
1 parent b2ed6a5 commit 92f1a2b

1 file changed

Lines changed: 14 additions & 4 deletions

File tree

cinderx/.clang-tidy

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,22 @@
1-
# Disable check for explicitly marking of functions which return 'null'. We
2-
# would have to use this excessively due to Python often using null to propagate
3-
# exceptions.
4-
51
InheritParentConfig: true
62

3+
# Explaining why some of our options are set:
4+
#
5+
# * Tracking nullable returns requires depending on folly, which we don't do.
6+
# It is also tedious as we would have to use this excessively due to Python
7+
# often using null to propagate exceptions.
8+
#
9+
# * std::regex has known issues with stack overflows, but we only use it in
10+
# tests and we don't do anything crazy with it. It's more convenient to use
11+
# it instead of pulling in a third party dependency like RE2.
12+
#
13+
# * The JIT converts between pointers and integers frequently, there's no way
14+
# to avoid this.
15+
716
Checks: '
817
-facebook-hte-NullableReturn,
918
-facebook-hte-GlibcRegexIsAwful,
1019
-facebook-hte-StdRegexIsAwful,
20+
-performance-no-int-to-ptr,
1121
modernize-raw-string-literal,
1222
'

0 commit comments

Comments
 (0)