Skip to content

Commit 991f39a

Browse files
alexmalyshevfacebook-github-bot
authored andcommitted
Reduce headers included from jit_list.h
Summary: Only needs cinderx/Common/ref.h. Reviewed By: mpage Differential Revision: D82545594 fbshipit-source-id: c80146ccd9476ef63bb5e0823705e90093901fd8
1 parent 6cac762 commit 991f39a

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

cinderx/Jit/jit_list.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,13 @@
22

33
#include "cinderx/Jit/jit_list.h"
44

5+
#include "cinderx/Common/log.h"
6+
#include "cinderx/Common/util.h"
57
#include "cinderx/Jit/config.h"
8+
#include "cinderx/Jit/threaded_compile.h"
69

710
#include <fstream>
11+
#include <stdexcept>
812
#include <string>
913

1014
namespace jit {

cinderx/Jit/jit_list.h

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,7 @@
22

33
#pragma once
44

5-
#include "cinderx/python.h"
6-
75
#include "cinderx/Common/ref.h"
8-
#include "cinderx/Common/util.h"
96

107
#include <memory>
118
#include <string_view>
@@ -25,6 +22,9 @@ class JITList {
2522
static std::unique_ptr<JITList> create();
2623
virtual ~JITList() {}
2724

25+
JITList(const JITList&) = delete;
26+
JITList& operator=(const JITList&) = delete;
27+
2828
// Parse a JIT list from a file.
2929
//
3030
// Raise an exception on error.
@@ -60,8 +60,6 @@ class JITList {
6060
std::string_view qualname);
6161

6262
private:
63-
DISALLOW_COPY_AND_ASSIGN(JITList);
64-
6563
// Add a code object's name to the JIT list. Return true on success.
6664
bool
6765
addEntryCode(BorrowedRef<> name, BorrowedRef<> file, BorrowedRef<> line_no);

0 commit comments

Comments
 (0)