Skip to content

Commit a334ee3

Browse files
hchokshifacebook-github-bot
authored andcommitted
Update CMake from 3.20.2 to 3.20.4
Summary: getdeps has been using CMake 3.20.2 since December 2021 (D32805140). CMake 3.20.2 maps `CMAKE_CXX_STANDARD 20` on MSVC to `/std:c++latest`. CMake 3.20.4 includes [this change](Kitware/CMake@3aaf1d9), which maps `CMAKE_CXX_STANDARD 20` on newer versions of MSVC to `/std:c++20`. This change allows OSS builds to build with `CMAKE_CXX_STANDARD 20` without getting dumped into `/std:c++latest`, which may jump to even newer versions than desired. --- This will allow us to build `fbthrift` OSS using C++ 20, and avoid OSS build breakages due to the discrepancy in C++ build standards (C++ 20 internally via Buck, C++ 17 in OSS via CMake) - e.g. D79365997. Reviewed By: chadaustin Differential Revision: D79590917 fbshipit-source-id: 552a68ae6854ff8482222b2fc164c7d6408e777a
1 parent 7c4b358 commit a334ee3

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

  • build/fbcode_builder/manifests

build/fbcode_builder/manifests/cmake

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,32 +18,32 @@ cmake
1818
ninja
1919

2020
[download.os=windows]
21-
url = https://github.com/Kitware/CMake/releases/download/v3.20.2/cmake-3.20.2-windows-x86_64.zip
22-
sha256 = 15a49e2ab81c1822d75b1b1a92f7863f58e31f6d6aac1c4103eef2b071be3112
21+
url = https://github.com/Kitware/CMake/releases/download/v3.20.4/cmake-3.20.4-windows-x86_64.zip
22+
sha256 = 965d2f001c3ca807d288f2b6b15c42b25579a0e73ef12c2a72c95f4c69123638
2323

2424
[download.os=darwin]
25-
url = https://github.com/Kitware/CMake/releases/download/v3.20.2/cmake-3.20.2-macos-universal.tar.gz
26-
sha256 = 0100663380a3bd977b001183cd487412db7aad9de6859927bde97e1e6e44e645
25+
url = https://github.com/Kitware/CMake/releases/download/v3.20.4/cmake-3.20.4-macos-universal.tar.gz
26+
sha256 = df90016635e3183834143c6d94607f0804fe9762f7cc6032f6a4afd7c19cd43b
2727

2828
[download.any(os=linux,os=freebsd)]
29-
url = https://github.com/Kitware/CMake/releases/download/v3.20.2/cmake-3.20.2.tar.gz
30-
sha256 = aecf6ecb975179eb3bb6a4a50cae192d41e92b9372b02300f9e8f1d5f559544e
29+
url = https://github.com/Kitware/CMake/releases/download/v3.20.4/cmake-3.20.4.tar.gz
30+
sha256 = 87a4060298f2c6bb09d479de1400bc78195a5b55a65622a7dceeb3d1090a1b16
3131

3232
[build.os=windows]
3333
builder = nop
34-
subdir = cmake-3.20.2-windows-x86_64
34+
subdir = cmake-3.20.4-windows-x86_64
3535

3636
[build.os=darwin]
3737
builder = nop
38-
subdir = cmake-3.20.2-macos-universal
38+
subdir = cmake-3.20.4-macos-universal
3939

4040
[install.files.os=darwin]
4141
CMake.app/Contents/bin = bin
4242
CMake.app/Contents/share = share
4343

4444
[build.any(os=linux,os=freebsd)]
4545
builder = cmakebootstrap
46-
subdir = cmake-3.20.2
46+
subdir = cmake-3.20.4
4747

4848
[make.install_args.any(os=linux,os=freebsd)]
4949
install

0 commit comments

Comments
 (0)