Skip to content

Commit a358193

Browse files
alexmalyshevfacebook-github-bot
authored andcommitted
Fix deprecation warning about test function returning non-None
Summary: All `test_` functions should return None, this one doesn't and raises a noisy DeprecationWarning. Reviewed By: DinoV Differential Revision: D81061284 fbshipit-source-id: a8d2ac156f13d32b55e8ed7bdf5a56fc1a8a6e6e
1 parent 5e0c850 commit a358193

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

cinderx/PythonLib/test_cinderx/test_cinderjit.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -798,9 +798,12 @@ def test_tmp_name2(self) -> None:
798798

799799
class JITCompileCrasherRegressionTests(StaticTestBase):
800800
@cinder_support.failUnlessJITCompiled
801-
def test_isinstance_optimization(self) -> None:
801+
def isinstance_optimization(self) -> bool:
802802
return isinstance(None, int) and True
803803

804+
def test_isinstance_optimization(self) -> None:
805+
self.assertFalse(self.isinstance_optimization())
806+
804807
@cinder_support.failUnlessJITCompiled
805808
def _fstring(self, flag, it1, it2):
806809
for a in it1:

0 commit comments

Comments
 (0)