Fix a few issues with primitive handling

Summary:
w1 is the "reg_general_auxilary_return_loc"  so when setting errors/success we should use that
umov reauires an index, we should use fmov
The move to the floating point error indicator needs to use fmov too

Reviewed By: yoney

Differential Revision: D93679174

fbshipit-source-id: 347b46fc116fa366d507526a376d676ae0b789dd

Author: DinoV

cinderx/Jit/codegen/autogen.cpp

@@ -269,7 +269,7 @@ void TranslateGuard(Environ* env, const Instruction* instr) {
     if (instr->getInput(2)->dataType() == jit::lir::OperandBase::kDouble) {
       JIT_CHECK(kind == kNotZero, "Only NotZero is supported for double")
       auto vecd_reg = AutoTranslator::getVecD(instr->getInput(2));
-      as->umov(reg, vecd_reg);
+      as->fmov(reg, vecd_reg);
       as->cbz(reg, deopt_label);
       is_double = true;
     } else {

cinderx/Jit/codegen/gen_asm.cpp

@@ -855,7 +855,7 @@ void* generateDeoptTrampoline(bool generator_mode) {
   // shared, we do this move unconditionally, but even if not needed, it's
   // harmless. (To eliminate it, we'd need another trampoline specifically for
   // deopt of primitive-returning functions, just to do this one move.)
-  a.mov(a64::w2, a64::w0);
+  a.mov(a64::w1, a64::w0);
   a.fmov(a64::d1, a64::x0);
 
   annot.add("resumeInInterpreter", &a, annot_cursor);
@@ -2133,11 +2133,11 @@ void NativeGenerator::generateEpilogue(BaseNode* epilogue_cursor) {
   if (func_->returnsPrimitive()) {
     JIT_CHECK(!is_gen, "generators can't return primitives");
     if (func_->returnsPrimitiveDouble()) {
-      // Loads an *integer* 1 in D0.. value doesn't matter,
+      // Loads an *integer* 1 in D1.. value doesn't matter,
       // but it needs to be non-zero.
-      as_->movi(a64::d0, 1);
+      as_->fmov(a64::d1, 1.0);
     } else {
-      as_->mov(a64::w2, 1);
+      as_->mov(a64::w1, 1);
     }
   }
 
@@ -3126,7 +3126,7 @@ NativeGenerator::generateBoxedReturnWrapper() {
     as_->fmov(arch::reg_scratch_0, a64::d1);
     as_->cbz(arch::reg_scratch_0, error);
   } else {
-    as_->cmp(a64::w2, 0);
+    as_->cmp(a64::w1, 0);
     as_->b_eq(box_done);
   }