Must not have '.' in manifest names as this breaks GitHub actions generation

Summary: There are probably some other rules too, although this is the only one I know of.

Reviewed By: martindemello

Differential Revision: D79474227

fbshipit-source-id: 175f266cb43f671da241e2d2ca289328b9e413d0

Author: jbower-fb

.github/workflows/getdeps_linux.yml

@@ -20,7 +20,7 @@ jobs:
     - uses: actions/checkout@v4
     - id: paths
       name: Query paths
-      run: python3 build/fbcode_builder/getdeps.py query-paths --recursive --src-dir=. cinderx-3.12mp  >> "$GITHUB_OUTPUT"
+      run: python3 build/fbcode_builder/getdeps.py query-paths --recursive --src-dir=. cinderx-3_12mp  >> "$GITHUB_OUTPUT"
     - name: Fetch ninja
       if: ${{ steps.paths.outputs.ninja_SOURCE }}
       run: python3 build/fbcode_builder/getdeps.py fetch --no-tests ninja
@@ -39,9 +39,9 @@ jobs:
     - name: Fetch libtool
       if: ${{ steps.paths.outputs.libtool_SOURCE }}
       run: python3 build/fbcode_builder/getdeps.py fetch --no-tests libtool
-    - name: Fetch meta-python-3.12
-      if: ${{ steps.paths.outputs.meta-python-3.12_SOURCE }}
-      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests meta-python-3.12
+    - name: Fetch meta-python-3_12
+      if: ${{ steps.paths.outputs.meta-python-3_12_SOURCE }}
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests meta-python-3_12
     - name: Restore ninja from cache
       id: restore_ninja
       if: ${{ steps.paths.outputs.ninja_SOURCE }}
@@ -138,29 +138,29 @@ jobs:
       with:
        path: ${{ steps.paths.outputs.libtool_INSTALL }}
        key: ${{ steps.paths.outputs.libtool_CACHE_KEY }}-install
-    - name: Restore meta-python-3.12 from cache
-      id: restore_meta-python-3.12
-      if: ${{ steps.paths.outputs.meta-python-3.12_SOURCE }}
+    - name: Restore meta-python-3_12 from cache
+      id: restore_meta-python-3_12
+      if: ${{ steps.paths.outputs.meta-python-3_12_SOURCE }}
       uses: actions/cache/restore@v4
       with:
-       path: ${{ steps.paths.outputs.meta-python-3.12_INSTALL }}
-       key: ${{ steps.paths.outputs.meta-python-3.12_CACHE_KEY }}-install
-    - name: Build meta-python-3.12
-      if: ${{ steps.paths.outputs.meta-python-3.12_SOURCE && ! steps.restore_meta-python-3.12.outputs.cache-hit }}
-      run: python3 build/fbcode_builder/getdeps.py build --no-tests meta-python-3.12
-    - name: Save meta-python-3.12 to cache
+       path: ${{ steps.paths.outputs.meta-python-3_12_INSTALL }}
+       key: ${{ steps.paths.outputs.meta-python-3_12_CACHE_KEY }}-install
+    - name: Build meta-python-3_12
+      if: ${{ steps.paths.outputs.meta-python-3_12_SOURCE && ! steps.restore_meta-python-3_12.outputs.cache-hit }}
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests meta-python-3_12
+    - name: Save meta-python-3_12 to cache
       uses: actions/cache/save@v4
-      if: ${{ steps.paths.outputs.meta-python-3.12_SOURCE && ! steps.restore_meta-python-3.12.outputs.cache-hit }}
+      if: ${{ steps.paths.outputs.meta-python-3_12_SOURCE && ! steps.restore_meta-python-3_12.outputs.cache-hit }}
       with:
-       path: ${{ steps.paths.outputs.meta-python-3.12_INSTALL }}
-       key: ${{ steps.paths.outputs.meta-python-3.12_CACHE_KEY }}-install
-    - name: Build cinderx-3.12mp
-      run: python3 build/fbcode_builder/getdeps.py build --src-dir=. cinderx-3.12mp --project-install-prefix cinderx-3.12mp:/usr/local
+       path: ${{ steps.paths.outputs.meta-python-3_12_INSTALL }}
+       key: ${{ steps.paths.outputs.meta-python-3_12_CACHE_KEY }}-install
+    - name: Build cinderx-3_12mp
+      run: python3 build/fbcode_builder/getdeps.py build --src-dir=. cinderx-3_12mp --project-install-prefix cinderx-3_12mp:/usr/local
     - name: Copy artifacts
-      run: python3 build/fbcode_builder/getdeps.py fixup-dyn-deps --strip --src-dir=. cinderx-3.12mp _artifacts/linux --project-install-prefix cinderx-3.12mp:/usr/local --final-install-prefix /usr/local
+      run: python3 build/fbcode_builder/getdeps.py fixup-dyn-deps --strip --src-dir=. cinderx-3_12mp _artifacts/linux --project-install-prefix cinderx-3_12mp:/usr/local --final-install-prefix /usr/local
     - uses: actions/upload-artifact@v4
       with:
-        name: cinderx-3.12mp
+        name: cinderx-3_12mp
         path: _artifacts
-    - name: Test cinderx-3.12mp
-      run: python3 build/fbcode_builder/getdeps.py test --src-dir=. cinderx-3.12mp --project-install-prefix cinderx-3.12mp:/usr/local
+    - name: Test cinderx-3_12mp
+      run: python3 build/fbcode_builder/getdeps.py test --src-dir=. cinderx-3_12mp --project-install-prefix cinderx-3_12mp:/usr/local

build/fbcode_builder/getdeps/manifest.py

@@ -255,6 +255,11 @@ def __init__(self, file_name, fp=None):
                 % (file_name, self.name)
             )
 
+        if "." in self.name:
+            raise Exception(
+                f"manifest name ({self.name}) must not contain the '.' character (it is incompatible with github actions)"
+            )
+
     def get(self, section, key, defval=None, ctx=None):
         ctx = ctx or {}
 

…/fbcode_builder/manifests/cinderx-3.12mp …/fbcode_builder/manifests/cinderx-3_12mpbuild/fbcode_builder/manifests/cinderx-3.12mp renamed to build/fbcode_builder/manifests/cinderx-3_12mp build/fbcode_builder/manifests/cinderx-3.12mp renamed to build/fbcode_builder/manifests/cinderx-3_12mp

@@ -1,5 +1,5 @@
 [manifest]
-name = cinderx-3.12mp
+name = cinderx-3_12mp
 fbsource_path = fbcode/cinderx
 shipit_project = facebookincubator/cinderx
 
@@ -14,7 +14,7 @@ builder = nop
 
 [dependencies]
 python-setuptools
-meta-python-3.12
+meta-python-3_12
 
 [shipit.pathmap]
 fbcode/cinderx = cinderx

…bcode_builder/manifests/meta-python-3.12 …bcode_builder/manifests/meta-python-3_12build/fbcode_builder/manifests/meta-python-3.12 renamed to build/fbcode_builder/manifests/meta-python-3_12 build/fbcode_builder/manifests/meta-python-3.12 renamed to build/fbcode_builder/manifests/meta-python-3_12

@@ -1,7 +1,7 @@
 # This is primarily to support CinderX, so it's not heavily configured.
 
 [manifest]
-name = meta-python-3.12
+name = meta-python-3_12
 fbsource_path = third-party/python/3.12
 shipit_project = facebookincubator/cinder
 shipit_fbcode_builder = false