Fix FT LIST_APPEND for lists and checked lists

Summary: Use PyList_Append for built-in lists while retaining the existing checked-list append path. Preserve stack-reference cleanup and regenerate the 3.14 interpreter cases.

Reviewed By: alexmalyshev

Differential Revision: D114353126

fbshipit-source-id: 85d41639fb7b273400d86f1d377b63fb393bf7de

Author: yoney

cinderx/Interpreter/3.14/Includes/generated_cases.c.h

@@ -9460,11 +9460,26 @@
             v = stack_pointer[-1];
             list = stack_pointer[-2 - (oparg-1)];
             #ifdef Py_GIL_DISABLED
-
-            int err = _PyList_AppendTakeRef((PyListObject *)PyStackRef_AsPyObjectBorrow(list),
-                PyStackRef_AsPyObjectSteal(v));
+            PyObject *lst = PyStackRef_AsPyObjectBorrow(list);
+            int err;
+            if (PyList_Check(lst)) {
+                _PyFrame_SetStackPointer(frame, stack_pointer);
+                err = PyList_Append(lst, PyStackRef_AsPyObjectBorrow(v));
+                stack_pointer = _PyFrame_GetStackPointer(frame);
+            }
+            else {
+                _PyFrame_SetStackPointer(frame, stack_pointer);
+                err = Ci_ListOrCheckedList_Append(
+                    (PyListObject *)lst, PyStackRef_AsPyObjectBorrow(v));
+                stack_pointer = _PyFrame_GetStackPointer(frame);
+            }
+            stack_pointer += -1;
+            assert(WITHIN_STACK_BOUNDS());
+            _PyFrame_SetStackPointer(frame, stack_pointer);
+            PyStackRef_CLOSE(v);
+            stack_pointer = _PyFrame_GetStackPointer(frame);
             if (err < 0) {
-                JUMP_TO_LABEL(pop_1_error);
+                JUMP_TO_LABEL(error);
             }
             #else
             _PyFrame_SetStackPointer(frame, stack_pointer);
@@ -9479,10 +9494,7 @@
             if (err < 0) {
                 JUMP_TO_LABEL(error);
             }
-            stack_pointer += 1;
             #endif
-            stack_pointer += -1;
-            assert(WITHIN_STACK_BOUNDS());
             DISPATCH();
         }
 

cinderx/Interpreter/3.14/cinder-bytecodes.c

@@ -507,9 +507,17 @@ dummy_func(
 
         override inst(LIST_APPEND, (list, unused[oparg-1], v -- list, unused[oparg-1])) {
 #ifdef Py_GIL_DISABLED
-            // T250369690: Need thread-safe checked collections
-            int err = _PyList_AppendTakeRef((PyListObject *)PyStackRef_AsPyObjectBorrow(list),
-                                           PyStackRef_AsPyObjectSteal(v));
+            PyObject *lst = PyStackRef_AsPyObjectBorrow(list);
+            int err;
+            if (PyList_Check(lst)) {
+                err = PyList_Append(lst, PyStackRef_AsPyObjectBorrow(v));
+            }
+            else {
+                // T250369690: Need thread-safe checked collections
+                err = Ci_ListOrCheckedList_Append(
+                    (PyListObject *)lst, PyStackRef_AsPyObjectBorrow(v));
+            }
+            PyStackRef_CLOSE(v);
             ERROR_IF(err < 0);
 #else
             int err = Ci_ListOrCheckedList_Append(