Modernize loops

Summary: Convert some of to loops to range-based loops.

Reviewed By: alexmalyshev

Differential Revision: D83292507

fbshipit-source-id: f43a79b7c56c726c33dbe2b3471b06a5ac913842

Author: yoney

cinderx/Jit/hir/printer.cpp

@@ -885,11 +885,10 @@ void HIRPrinter::Print(std::ostream& os, const FrameState& state) {
   }
 
   auto& bs = state.block_stack;
-  if (bs.size() > 0) {
+  if (!bs.isEmpty()) {
     Indented(os) << "BlockStack {" << std::endl;
     Indent();
-    for (std::size_t i = 0; i < bs.size(); i++) {
-      auto& entry = bs.at(i);
+    for (const auto& entry : bs) {
       Indented(os) << fmt::format(
           "Opcode {} HandlerOff {} StackLevel {}\n",
           entry.opcode,

cinderx/Jit/hir/simplify.cpp

@@ -1816,10 +1816,7 @@ void Simplify::Run(Function& irfunc) {
        changed && i < iteration_limit && env.new_blocks < new_block_limit;
        ++i) {
     changed = false;
-    for (auto cfg_it = irfunc.cfg.blocks.begin();
-         cfg_it != irfunc.cfg.blocks.end();
-         ++cfg_it) {
-      BasicBlock& block = *cfg_it;
+    for (auto& block : irfunc.cfg.blocks) {
       env.block = &block;
 
       for (auto blk_it = block.begin(); blk_it != block.end();) {

cinderx/Jit/jit_time_log.cpp

@@ -111,25 +111,22 @@ void CompilationPhaseTimer::dumpPhaseTimingsAndTidy() {
   int ts_digits = 0;
   int unattributed_time_digitls = 0;
   double leaf_total_time = 0;
-  for (auto it = flat_rows.begin(); it != flat_rows.end(); ++it) {
-    auto& [indent, phase, time_span, is_leaf, unattributed_time] = *it;
-
+  for (auto& [indent, phase, time_span, is_leaf, unattributed_time] :
+       flat_rows) {
     longest_phase =
         std::max(longest_phase, int(phase->sub_phase_name.size() + 1 + indent));
     ts_digits = std::max(ts_digits, int(log10(time_span) + 1));
     unattributed_time_digitls =
         std::max(unattributed_time_digitls, int(log10(unattributed_time) + 1));
 
     if (is_leaf) {
-      int time_span = std::get<2>(*it);
       leaf_total_time += time_span;
     }
   }
 
   std::string phase_info;
-  for (auto it = flat_rows.begin(); it != flat_rows.end(); ++it) {
-    auto& [indent, phase, time_span, is_leaf, unattributed_time] = *it;
-
+  for (auto& [indent, phase, time_span, is_leaf, unattributed_time] :
+       flat_rows) {
     phase_info += fmt::format(
         "{:<{}}",
         fmt::format("{}>{}", std::string(indent, ' '), phase->sub_phase_name),

cinderx/Jit/lir/inliner.cpp

@@ -17,6 +17,8 @@ bool LIRInliner::inlineCalls(Function* func) {
   bool changed = false;
   std::vector<BasicBlock*>& blocks = func->basicblocks();
 
+  // Do not convert to a range-based for loop because 'blocks' is updated
+  // inside the loop.
   for (size_t i = 0; i < blocks.size(); ++i) {
     BasicBlock* bb = blocks[i];