Skip to content

Commit c3ea5e7

Browse files
yoneymeta-codesync[bot]
authored andcommitted
Enable RuntimeTests for 3.14-interp-loop-only
Summary: Enable C++ runtime tests for 3.14-interp-loop-only and skip HIR goldens that depend on unavailable features. Reviewed By: DinoV Differential Revision: D114787265 fbshipit-source-id: 8d36f1a87a32fa7561ebfbc6bfac5f4a145aecb8
1 parent d6de382 commit c3ea5e7

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

cinderx/RuntimeTests/main.cpp

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,10 @@ void remap_txt_path(std::string& path) {
112112
void register_test(
113113
std::string path,
114114
RuntimeTest::Flags extra_flags = RuntimeTest::Flags{}) {
115-
#ifdef CINDERX_RUNTIME_TESTS_FEATURE_FREE
116-
// Feature-free builds cannot execute Static Python bytecode.
115+
#if defined(CINDERX_RUNTIME_TESTS_FEATURE_FREE) || \
116+
defined(CINDERX_RUNTIME_TESTS_INTERP_LOOP_ONLY)
117+
// Minimal builds do not support the full set of features assumed by Static
118+
// Python goldens.
117119
if (extra_flags & RuntimeTest::kStaticCompiler) {
118120
return;
119121
}
@@ -267,7 +269,8 @@ int main(int argc, char* argv[]) {
267269
RuntimeTest::kStaticCompiler);
268270
register_test("builtin_load_method_elimination_test.txt");
269271
register_test("leaf_function_test.txt");
270-
#ifndef CINDERX_RUNTIME_TESTS_FEATURE_FREE
272+
#if !defined(CINDERX_RUNTIME_TESTS_FEATURE_FREE) && \
273+
!defined(CINDERX_RUNTIME_TESTS_INTERP_LOOP_ONLY)
271274
// These goldens depend on lightweight frames and symbolized call targets.
272275
register_test("all_passes_test.txt");
273276
#endif

0 commit comments

Comments
 (0)