Test cibuildwheel Github workflow

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Author: Bot

.github/workflows/wheels.yml

@@ -0,0 +1,32 @@
+name: Build
+
+on: [push, pull_request]
+
+jobs:
+  build_wheels:
+    name: Build wheels on ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        #os: [ubuntu-latest, ubuntu-24.04-arm, windows-latest, windows-11-arm, macos-15-intel, macos-latest]
+        os: [ubuntu-latest]
+
+    steps:
+      - uses: actions/checkout@v5
+
+      # Used to host cibuildwheel
+      - uses: actions/setup-python@v5
+
+      - name: Install cibuildwheel
+        run: python -m pip install cibuildwheel
+
+      - name: Build wheels
+        run: python -m cibuildwheel --output-dir wheelhouse
+        env:
+          CIBW_BUILD: cp314-manylinux_x86_64
+          CIBW_BUILD_VERBOSITY: 3
+
+      - uses: actions/upload-artifact@v4
+        with:
+          name: cibw-wheels-${{ matrix.os }}-${{ strategy.job-index }}
+          path: ./wheelhouse/*.whl

CMakeLists.txt

@@ -64,7 +64,7 @@ include(FetchContent)
 ########################################
 # python
 
-find_package(Python ${PY_VERSION} EXACT REQUIRED COMPONENTS Development)
+find_package(Python ${PY_VERSION} EXACT COMPONENTS Interpreter Development.Module REQUIRED)
 
 # Some of our files are partially generated from CPython source, and they
 # expect to be able to include files relative to Include/internal.

cinderx/Jit/perf_jitdump.cpp

@@ -61,14 +61,16 @@ const size_t kJitdumpMmapSize = 1;
 // C++-friendly wrapper around strerror_r().
 std::string string_error(int errnum) {
   char buf[1024];
-  // There's two forms of strerror_r(), one that returns a string and one that
-  // returns an int.
-#if __APPLE__
-  strerror_r(errnum, buf, sizeof(buf));
-  return std::string{buf};
-#else
-  return strerror_r(errnum, buf, sizeof(buf));
-#endif
+  // This template trick detects the return type of strerror_r at compile time.
+  // If it returns char*, we're using GNU version. If it returns int, POSIX.
+  if constexpr (std::is_same_v<decltype(strerror_r(0, buf, 0)), char*>) {
+    // GNU version: returns char* (possibly pointing to a static string)
+    return strerror_r(errnum, buf, sizeof(buf));
+  } else {
+    // POSIX version: returns int, writes to buffer
+    strerror_r(errnum, buf, sizeof(buf));
+    return std::string{buf};
+  }
 }
 
 class FileLock {

setup.py

@@ -119,8 +119,10 @@ def _run_cmake(self, extension: CMakeExtension) -> None:
         extension_dir = os.path.abspath(self.get_ext_fullpath(extension.name))
         os.makedirs(extension_dir, exist_ok=True)
 
-        cc = self._find_binary("clang")
-        cxx = self._find_binary("clang++")
+        # Prefer Clang because that's what we develop against but some systems
+        # including the manylinux build environment only have GCC.
+        cc = shutil.which("clang") or shutil.which("gcc")
+        cxx = shutil.which("clang++") or shutil.which("g++")
 
         build_type = os.environ.get("CMAKE_BUILD_TYPE", "RelWithDebInfo")
         cmake_args = [
@@ -184,12 +186,6 @@ def set_option(var: str, default: object) -> None:
         self.spawn(["cmake"] + cmake_args + ["-B", build_dir, CHECKOUT_ROOT_DIR])
         self.spawn(["cmake", "--build", build_dir] + build_args)
 
-    def _find_binary(self, name: str) -> str:
-        result = shutil.which(name)
-        if result is None:
-            raise RuntimeError(f"Cannot find `{name}` binary")
-        return result
-
     def _find_python(self) -> str:
         # Normally this would use "data", but that goes to a temporary build directory
         # under uv.  Work off of the include directory instead.