{Pyrefly] Add property test and support

Summary: Adds a test case for invoking properties - fixes the one issue which causes inexact code gen where we are getting exact types by default.

Reviewed By: martindemello

Differential Revision: D96226921

fbshipit-source-id: df661444f4a66a2ba672941bd2e7fada495e674b

Author: DinoV

cinderx/PythonLib/cinderx/compiler/static/pyrefly_compiler.py

@@ -8,7 +8,7 @@
 from cinderx.compiler.static.pyrefly_info import EMPTY_TYPE_INFO, Pyrefly
 from cinderx.compiler.static.pyrefly_type_binder import PyreflyTypeBinder
 from cinderx.compiler.static.type_binder import TypeBinder
-from cinderx.compiler.strict.compiler import Compiler
+from cinderx.compiler.strict.compiler import Compiler, TIMING_LOGGER_TYPE
 from cinderx.compiler.strict.flag_extractor import Flags
 from cinderx.compiler.symbols import SymbolVisitor
 

cinderx/PythonLib/cinderx/compiler/static/pyrefly_info.py

@@ -186,7 +186,7 @@ def resolve_classname(
                     if result is None:
                         return None
                 if isinstance(result, Class):
-                    return result
+                    return result.inexact_type()
                 elif isinstance(result, Value):
                     return result.klass
                 return None

cinderx/PythonLib/test_cinderx/test_compiler/test_static/pyreflybinder.py

@@ -0,0 +1,117 @@
+{
+  "type_table": [
+    {
+      "kind": "class",
+      "qname": "builtins.property",
+      "args": [],
+      "hash": 6891147978376177783
+    },
+    {
+      "kind": "other_form",
+      "qname": "typing.Type",
+      "args": [
+        0
+      ],
+      "hash": 1202475085224118155
+    },
+    {
+      "kind": "class",
+      "qname": "builtins.int",
+      "args": [],
+      "hash": 7437843174258217660
+    },
+    {
+      "kind": "other_form",
+      "qname": "typing.Type",
+      "args": [
+        2
+      ],
+      "hash": 6510812805515236383
+    },
+    {
+      "kind": "literal",
+      "value": "42",
+      "promoted_type": 2,
+      "hash": 8499067216537500750
+    },
+    {
+      "kind": "class",
+      "qname": "cinderx.PythonLib.test_cinderx.test_compiler.test_static.pyreflytests.property.C",
+      "args": [],
+      "hash": 18418907475535762116
+    },
+    {
+      "kind": "other_form",
+      "qname": "typing.Type",
+      "args": [
+        5
+      ],
+      "hash": 3047767295098807706
+    }
+  ],
+  "locations": [
+    {
+      "loc": {
+        "start_line": 2,
+        "start_col": 5,
+        "end_line": 2,
+        "end_col": 13
+      },
+      "type": 1
+    },
+    {
+      "loc": {
+        "start_line": 3,
+        "start_col": 19,
+        "end_line": 3,
+        "end_col": 22
+      },
+      "type": 3
+    },
+    {
+      "loc": {
+        "start_line": 4,
+        "start_col": 15,
+        "end_line": 4,
+        "end_col": 17
+      },
+      "type": 4
+    },
+    {
+      "loc": {
+        "start_line": 7,
+        "start_col": 11,
+        "end_line": 7,
+        "end_col": 14
+      },
+      "type": 3
+    },
+    {
+      "loc": {
+        "start_line": 8,
+        "start_col": 11,
+        "end_line": 8,
+        "end_col": 16
+      },
+      "type": 2
+    },
+    {
+      "loc": {
+        "start_line": 8,
+        "start_col": 11,
+        "end_line": 8,
+        "end_col": 14
+      },
+      "type": 5
+    },
+    {
+      "loc": {
+        "start_line": 8,
+        "start_col": 11,
+        "end_line": 8,
+        "end_col": 12
+      },
+      "type": 6
+    }
+  ]
+}

cinderx/PythonLib/test_cinderx/test_compiler/test_static/pyreflytests/property.json

@@ -0,0 +1,8 @@
+class C:
+    @property
+    def f(self) -> int:
+        return 42
+
+
+def g() -> int:
+    return C().f

cinderx/PythonLib/test_cinderx/test_compiler/test_static/pyreflytests/property.py

@@ -0,0 +1,10 @@
+from types import CodeType
+
+from test_cinderx.test_compiler.test_static.pyrefly_binder import PyreBinderTests
+
+
+def verify(test: PyreBinderTests, code: CodeType) -> None:
+    """Verify that the compiled code includes INVOKE_METHOD."""
+
+    g = test.find_code(code, "g")
+    test.assertInBytecode(g, "INVOKE_METHOD")