Skip to content

Commit f0bb308

Browse files
alexmalyshevmeta-codesync[bot]
authored andcommitted
Fix simplifyStoreSubscr missing a UseType
Summary: Another case of the JIT depending on a type produced by a guard, without registering that dependency. This led to the crash in T259580456. Reviewed By: yoney Differential Revision: D96934158 fbshipit-source-id: bdf946134b677683aa76371cdda78e68d5cb352b
1 parent d219116 commit f0bb308

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

cinderx/Jit/hir/simplify.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1907,6 +1907,7 @@ Register* simplifyVectorCall(Env& env, const VectorCall* instr) {
19071907

19081908
Register* simplifyStoreSubscr(Env& env, const StoreSubscr* instr) {
19091909
if (instr->GetOperand(0)->isA(TDictExact)) {
1910+
env.emit<UseType>(instr->GetOperand(0), TDictExact);
19101911
auto output = env.func.env.AllocateRegister();
19111912
env.emitRawInstr<CallStatic>(
19121913
3,

0 commit comments

Comments
 (0)