Skip to content

Commit fd8e5a8

Browse files
alexmalyshevmeta-codesync[bot]
authored andcommitted
bugfix: add missing include_code_size arg to parse_jit_log calls
Summary: The `find_missing_type` subcommand calls `parse_jit_log()` without the required `include_code_size` parameter, which would cause a `TypeError` at runtime. Added `include_code_size=False` since this subcommand doesn't use code size data. Reviewed By: yoney Differential Revision: D97805943 fbshipit-source-id: d7095e8486073807e505202d5b30ccfc0f51ba48
1 parent 54cb7a8 commit fd8e5a8

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

cinderx/TestScripts/jit_log_stats_parser.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -739,8 +739,8 @@ def main():
739739
sys.exit(0)
740740

741741
elif args.command == "find_missing_type":
742-
function_data1 = parse_jit_log(args.log_file1)
743-
function_data2 = parse_jit_log(args.log_file2)
742+
function_data1 = parse_jit_log(args.log_file1, include_code_size=False)
743+
function_data2 = parse_jit_log(args.log_file2, include_code_size=False)
744744

745745
missing_type_functions = find_functions_missing_type(
746746
function_data1, function_data2, args.type_name

0 commit comments

Comments
 (0)