Must not have '.' in manifest names as this breaks GitHub actions generation

Summary: There are probably some other rules too, although this is the only one I know of.

Reviewed By: martindemello

Differential Revision: D79474227

fbshipit-source-id: 175f266cb43f671da241e2d2ca289328b9e413d0

Author: jbower-fb

build/fbcode_builder/getdeps/manifest.py

@@ -255,6 +255,11 @@ def __init__(self, file_name, fp=None):
                 % (file_name, self.name)
             )
 
+        if "." in self.name:
+            raise Exception(
+                f"manifest name ({self.name}) must not contain the '.' character (it is incompatible with github actions)"
+            )
+
     def get(self, section, key, defval=None, ctx=None):
         ctx = ctx or {}
 

…/fbcode_builder/manifests/cinderx-3.12mp …/fbcode_builder/manifests/cinderx-3_12mpbuild/fbcode_builder/manifests/cinderx-3.12mp renamed to build/fbcode_builder/manifests/cinderx-3_12mp build/fbcode_builder/manifests/cinderx-3.12mp renamed to build/fbcode_builder/manifests/cinderx-3_12mp

@@ -1,5 +1,5 @@
 [manifest]
-name = cinderx-3.12mp
+name = cinderx-3_12mp
 fbsource_path = fbcode/cinderx
 shipit_project = facebookincubator/cinderx
 
@@ -14,7 +14,7 @@ builder = nop
 
 [dependencies]
 python-setuptools
-meta-python-3.12
+meta-python-3_12
 
 [shipit.pathmap]
 fbcode/cinderx = cinderx

…bcode_builder/manifests/meta-python-3.12 …bcode_builder/manifests/meta-python-3_12build/fbcode_builder/manifests/meta-python-3.12 renamed to build/fbcode_builder/manifests/meta-python-3_12 build/fbcode_builder/manifests/meta-python-3.12 renamed to build/fbcode_builder/manifests/meta-python-3_12

@@ -1,7 +1,7 @@
 # This is primarily to support CinderX, so it's not heavily configured.
 
 [manifest]
-name = meta-python-3.12
+name = meta-python-3_12
 fbsource_path = third-party/python/3.12
 shipit_project = facebookincubator/cinder
 shipit_fbcode_builder = false