Skip to content

Commit 40f9d95

Browse files
simonmarfacebook-github-bot
authored andcommitted
Strip leading zeroes in the folly-clib version (#161)
Summary: Cabal doesn't like leading zeroes. Fixes this CI failure: https://github.com/facebookincubator/hsthrift/actions/runs/16375702901/job/46274980740 ``` Errors encountered when parsing cabal file folly-clib/folly-clib.cabal: folly-clib/folly-clib.cabal:3:33: error: unexpected Version digit with leading zero 2 | name: folly-clib 3 | version: 20250718.056 | ^ ``` Pull Request resolved: #161 Reviewed By: malanka Differential Revision: D78729684 Pulled By: pepeiborra fbshipit-source-id: 67052e35a1d9dc28e1599c042966c889b1dd6f97
1 parent c5a1920 commit 40f9d95

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ setup-folly::
181181
# that respects Cabal's constraints on version numbers: no leading
182182
# zeroes and fields must be <10 digits.
183183
.PHONY: setup-folly-version setup-folly-0
184-
ver:=$(shell cd folly-clib/folly && date -u "--date=@$$(git log -1 --format=%ct)" +%Y%m%d.%-k%M)
184+
ver:=$(shell cd folly-clib/folly && date -u "--date=@$$(git log -1 --format=%ct)" +%Y%m%d.%-k%M | sed 's/\.0*/\./')
185185
setup-folly-version::
186186
sed -i "s/^version:\(\s*\).*$$/version:\1$(ver)/" folly-clib/folly-clib.cabal
187187
sed -i "s/^\(\s*\)build-depends:\(\s*\)folly-clib\s*$$/\1build-depends: folly-clib==$(ver)/" common/util/fb-util.cabal

0 commit comments

Comments
 (0)