Commit 9f3dd89
fix(build): bump glog pin past cmake_policy(VERSION 3.3) breakage
Summary:
## Problem
`Docker Build AMD64` and `Docker Build Interop Client AMD64` fail at the glog configure step:
```
CMake Error at cmake/GetCacheVariables.cmake:2 (cmake_policy):
Compatibility with CMake < 3.5 has been removed from CMake.
```
glog at the currently-pinned rev (v0.6.0, `b33e3bad`) uses `cmake_policy(VERSION 3.3)`. CMake 4.x dropped that compat path. Both Dockerfiles use `FROM ubuntu:latest`, which now ships CMake 4.x. GitHub-runner workflows (`ubuntu-22.04`) still ship CMake 3.22.x and are unaffected.
Upgrading to glog v0.7.x is blocked because v0.7.0 raises `cmake_minimum_required` to 3.22, above getdeps' 3.20.4 floor (as the existing manifest comment notes).
## Fix
Bump glog rev to `3411d58669` — the last master commit before glog v0.7.0 raised cmake_minimum. It carries the `cmake_policy(VERSION 3.16...3.27)` fix in `cmake/GetCacheVariables.cmake` and still declares `cmake_minimum_required(VERSION 3.16)`.
Same approach as folly's [`build/fbcode_builder/manifests/libevent`](https://github.com/facebook/folly/blob/main/build/fbcode_builder/manifests/libevent) (master-commit pin, explicitly to avoid `CMAKE_POLICY_VERSION_MINIMUM=3.5`).
X-link: facebookexperimental/moxygen#163
Reviewed By: jbeshay
Differential Revision: D105388038
Pulled By: afrind
fbshipit-source-id: 9473b1ad7f840e49350f7b88f0ceac796245400a1 parent 89e6a6a commit 9f3dd89
1 file changed
Lines changed: 7 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
7 | 10 | | |
8 | 11 | | |
9 | | - | |
| 12 | + | |
10 | 13 | | |
11 | 14 | | |
12 | 15 | | |
| |||
0 commit comments