Skip to content

Commit bb41b52

Browse files
simonmarfacebook-github-bot
authored andcommitted
Build fast_float from source (#145)
Summary: Folly requires a more up-to-date fast_float than the one in Ubuntu 24, so CI is currently using Ubuntu 25. But a better solution is to build fast_float from source, and then we can revert the CI to use Ubuntu 24, so that we're back on an LTS release. Pull Request resolved: #145 Reviewed By: malanka Differential Revision: D71552122 Pulled By: iamirzhan fbshipit-source-id: 962b1208289681cbcd658080fd28856244a932a4
1 parent c93128f commit bb41b52

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

.github/workflows/ci-getdeps.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
ghc: [8.6.5, 8.8.4, 8.10.7, 9.2.8]
1414
runs-on: ubuntu-latest
1515
container:
16-
image: ubuntu:25.04
16+
image: ubuntu:24.04
1717
options: --security-opt=seccomp=unconfined
1818
env:
1919
LD_LIBRARY_PATH: "/github/home/.hsthrift/lib"
@@ -79,7 +79,6 @@ jobs:
7979
libxxhash-dev
8080
libgtest-dev
8181
libtinfo-dev
82-
libfast-float-dev
8382
8483
- name: Setup Haskell
8584
run: |

new_install_deps.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ THREADS=4
1414
# These are required source deps not satisifiable with common package systems
1515
# in topological order. You can pass additional deps on the command line.
1616
#
17-
BASE_DEPS="fmt folly"
17+
BASE_DEPS="fmt fast_float folly"
1818
FBTHRIFT_DEPS="fizz wangle mvfst fbthrift"
1919
EXTRA_DEPS=""
2020

0 commit comments

Comments
 (0)