Annotate uses of non-sealed key types: fbcode/common/hs/

Reviewed By: vitaut

Differential Revision: D96427309

fbshipit-source-id: ec8f2dcfa37977a257a2a903f14f85fe33df17f6

Author: aristidisp

exactprint/tests/fbthrift-tests/complex-struct/src/module.thrift

@@ -77,6 +77,7 @@ struct MyStruct {
   21: map<i32, i32> mIntegerInteger;
   22: map<i32, bool> mIntegerBool;
   23: set<i16> sShort;
+  @thrift.AllowUnsafeNonSealedKeyType
   24: set<MyStruct> sMyStruct;
   25: set<i64> sLong;
   26: set<string> sString;
@@ -169,6 +170,7 @@ struct ComplexNestedStruct {
   4: set<list<list<i64>>> setOfListOfListOfLong;
   5: set<set<set<i64>>> setOfSetOfsetOfLong;
   6: map<i32, list<list<MyStruct>>> mapStructListOfListOfLong;
+  @thrift.AllowUnsafeNonSealedKeyType
   7: map<MyStruct, i32> mKeyStructValInt;
   8: list<map<i32, i32>> listOfMapKeyIntValInt;
   9: list<map<string, list<MyStruct>>> listOfMapKeyStrValList;
@@ -228,11 +230,15 @@ struct Containers {
   2: list<MyUnion> union_list;
   3: list<MyEnum> enum_list;
 
+  @thrift.AllowUnsafeNonSealedKeyType
   4: set<MyStruct> struct_set;
+  @thrift.AllowUnsafeNonSealedKeyType
   5: set<MyUnion> union_set;
   6: set<MyEnum> enum_set;
 
+  @thrift.AllowUnsafeNonSealedKeyType
   7: map<MyStruct, i64> struct_map;
+  @thrift.AllowUnsafeNonSealedKeyType
   8: map<MyUnion, i64> union_map;
   9: map<MyEnum, i64> enum_map;
 
@@ -258,11 +264,15 @@ struct Containers {
   25: list<map<MyStruct, i32>> list_map_struct_i32;
 
   26: set<list<i32>> set_list_i32;
+  @thrift.AllowUnsafeNonSealedKeyType
   27: set<list<MyStruct>> set_list_struct;
   28: set<set<i32>> set_set_i32;
+  @thrift.AllowUnsafeNonSealedKeyType
   29: set<set<MyStruct>> set_set_struct;
   30: set<map<i32, i32>> set_map_i32_i32;
+  @thrift.AllowUnsafeNonSealedKeyType
   31: set<map<i32, MyStruct>> set_map_i32_struct;
+  @thrift.AllowUnsafeNonSealedKeyType
   32: set<map<MyStruct, i32>> set_map_struct_i32;
 
   33: map<i32, map<i32, i32>> map_i32_map_i32_i32;

exactprint/tests/fbthrift-tests/complex-union/src/invariant.thrift

@@ -35,6 +35,8 @@ struct UnionForInvariantTypes {
 }
 
 union InvariantTypes {
+  @thrift.AllowUnsafeNonSealedKeyType
   1: map<StructForInvariantTypes, i64> struct_map;
+  @thrift.AllowUnsafeNonSealedKeyType
   2: map<UnionForInvariantTypes, i64> union_map;
 }

exactprint/tests/fbthrift-tests/cpp2-struct-footprint/src/module.thrift

@@ -59,6 +59,7 @@ typedef i32 MyInt
 typedef SimpleStruct MyStruct
 typedef list<SimpleStruct> StructList
 typedef map<string, SimpleStruct> StructMap
+@thrift.AllowUnsafeNonSealedKeyType
 typedef set<SimpleStruct> StructSet
 
 // Interaction for testing interaction constructors

exactprint/tests/fbthrift-tests/encode/src/module.thrift

@@ -57,7 +57,9 @@ struct OpEncodeStruct {
   @cpp.Ref{type = cpp.RefType.Shared}
   6: optional list<AdaptedFoo> list_shared_ptr_field;
   7: list<AdaptedFoo> list_cpp_type_field;
+  @thrift.AllowUnsafeNonSealedKeyType
   8: set<AdaptedFoo> set_field;
+  @thrift.AllowUnsafeNonSealedKeyType
   9: map<AdaptedFoo, AdaptedFoo> map_field;
   10: map<i32, list<AdaptedFoo>> nested_field;
   11: Bar bar_field;

exactprint/tests/fbthrift-tests/fatal/src/module.thrift

@@ -128,6 +128,7 @@ struct structC {
   14: set<i32> k;
   15: set<i32> k1;
   16: set<enum2> k2;
+  @thrift.AllowUnsafeNonSealedKeyType
   17: set<structB> k3;
   18: map<i32, i32> l;
   19: map<i32, i32> l1;
@@ -139,8 +140,11 @@ struct structC {
   25: map<string, i32> n1;
   26: map<string, enum1> n2;
   27: map<string, structB> n3;
+  @thrift.AllowUnsafeNonSealedKeyType
   28: map<structA, i32> o1;
+  @thrift.AllowUnsafeNonSealedKeyType
   29: map<structA, enum1> o2;
+  @thrift.AllowUnsafeNonSealedKeyType
   30: map<structA, structB> o3;
 }
 
@@ -181,6 +185,7 @@ struct struct3 {
   13: set<i32> fieldM;
   14: set<string> fieldN;
   15: set<string> fieldO;
+  @thrift.AllowUnsafeNonSealedKeyType
   16: set<structB> fieldP;
   17: map<string, structA> fieldQ;
   18: map<string, structB> fieldR;

exactprint/tests/fbthrift-tests/go-service/src/module.thrift

@@ -34,6 +34,7 @@ struct GetEntityResponse {
 struct NonComparableStruct {
   1: string foo;
   2: list<string> bar;
+  @thrift.AllowUnsafeNonSealedKeyType
   3: map<NonComparableStruct, i64> baz;
 }
 

exactprint/tests/fbthrift-tests/go-typedef/src/module1.thrift

@@ -53,6 +53,7 @@ struct MapKey {
 }
 
 struct MapContainer {
+  @thrift.AllowUnsafeNonSealedKeyType
   1: map<MapKey, string> mapval;
 }
 

exactprint/tests/fbthrift-tests/hack_field_wrapper_with_arrays/src/include.thrift

@@ -58,6 +58,7 @@ struct MyNestedStruct {
   5: optional i64WithAdapter optional_adapted_and_wrapped_type;
   @hack.FieldWrapper{name = "\\MyFieldWrapper"}
   @hack.SkipCodegen{reason = "invalid map key"}
+  @thrift.AllowUnsafeNonSealedKeyType
   6: optional map<MyStruct, string> invalid_key_map;
   @hack.FieldWrapper{name = "\\MyFieldWrapper"}
   7: i64WithWrapper wrapped_type_int;

exactprint/tests/fbthrift-tests/mcpp2-compare/src/module.thrift

@@ -129,6 +129,7 @@ union SimpleUnion {
 typedef i32 simpleTypeDef
 typedef map<i16, string> containerTypeDef
 typedef list<map<i16, string>> complexContainerTypeDef
+@thrift.AllowUnsafeNonSealedKeyType
 typedef set<SimpleUnion> unionTypeDef
 typedef list<MyStruct> structTypeDef
 typedef list<map<Empty, MyStruct>> complexStructTypeDef
@@ -150,6 +151,7 @@ union ComplexUnion {
   12: MyEnumA enum_field;
   13: list<MyEnumA> enum_container;
   14: MyStruct a_struct;
+  @thrift.AllowUnsafeNonSealedKeyType
   15: set<MyStruct> a_set_struct;
   16: SimpleUnion a_union;
   216: SimpleUnion opt_a_union;
@@ -182,6 +184,7 @@ exception AnException {
   6: MyEnumA enum_field;
   7: list<MyEnumA> enum_container;
   8: MyStruct a_struct;
+  @thrift.AllowUnsafeNonSealedKeyType
   9: set<MyStruct> a_set_struct;
   10: list<SimpleUnion> a_union_list;
   11: unionTypeDef union_typedef;
@@ -239,6 +242,7 @@ struct ContainerStruct {
   23: MyStruct fieldV;
   123: required MyStruct req_fieldV;
   223: optional MyStruct opt_fieldV;
+  @thrift.AllowUnsafeNonSealedKeyType
   24: set<MyStruct> fieldW;
   25: ComplexUnion fieldX;
   125: required ComplexUnion req_fieldX;
@@ -433,6 +437,7 @@ service ParamService {
   i64 i64_ret_float_double_param(1: float param1, 3: double param2);
   i64 i64_ret_string_typedef_param(
     1: string param1,
+    @thrift.AllowUnsafeNonSealedKeyType
     3: set<mostComplexTypeDef> param2,
   );
   @cpp.ProcessInEbThreadUnsafe
@@ -443,7 +448,10 @@ service ParamService {
     4: i32 param4,
     5: i32 param5,
   );
-  double double_ret_setstruct_param(4: set<MyStruct> param1);
+  double double_ret_setstruct_param(
+    @thrift.AllowUnsafeNonSealedKeyType
+    4: set<MyStruct> param1,
+  );
   string string_ret_string_param(1: string param1);
   binary binary_ret_binary_param(1: binary param1);
   map<string, i64> map_ret_bool_param(1: bool param1);

exactprint/tests/fbthrift-tests/py-hidden/src/module.thrift

@@ -32,6 +32,7 @@ struct S1 {
   1: i32 normalField;
 
   @python.PyDeprecatedHidden{reason = "Structured keys not supported"}
+  @thrift.AllowUnsafeNonSealedKeyType
   2: map<StructuredKey, StructuredKey> mapField;
 }