Skip to content

Commit 12a7dae

Browse files
Ivan Morettfacebook-github-bot
authored andcommitted
libelf update to newer version
Summary: I updated earlier libbpf to use latest version as it was needed for newer functionalities in katran. In sandcastle the workflow worked due to the packages manager definitions: ``` [rpms] elfutils-libelf-devel-static [debs] libelf-dev [pps] libelf ``` they just point to the library name which uses the latest, e.g. https://archlinux.org/packages/?sort=&q=libelf&maintainer=&flagged= https://packages.debian.org/search?keywords=libelf-dev&searchon=names&suite=trixie&section=all in open source it failed probably because it downloaded it which is a really old library: https://github.com/facebookincubator/katran/actions/runs/17864398197/job/50803066377 Updating the definition of download library to have the most recent version. Once this was updated, decap/testing complained about linking issue with zstd so adding it in their CMakeList too For libelf the only user is libbpf https://fburl.com/code/j4oajn8k which katran is the only user Reviewed By: pdubovitsky Differential Revision: D82858998 fbshipit-source-id: b4b6cba9ec03eab57322527d925fcb2f4d4393df
1 parent 193b38f commit 12a7dae

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

build/fbcode_builder/manifests/libelf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ libelf-dev
1111
libelf
1212

1313
[download]
14-
url = https://ftp.osuosl.org/pub/blfs/conglomeration/libelf/libelf-0.8.13.tar.gz
15-
sha256 = 591a9b4ec81c1f2042a97aa60564e0cb79d041c52faa7416acb38bc95bd2c76d
14+
url = https://sourceware.org/elfutils/ftp/0.193/elfutils-0.193.tar.bz2
15+
sha256 = 7857f44b624f4d8d421df851aaae7b1402cfe6bcdd2d8049f15fc07d3dde7635
1616

1717
# libelf only makes sense on linux, so make it a NOP on other platforms
1818
[build.not(os=linux)]
1919
builder = nop
2020

2121
[build.os=linux]
2222
builder = autoconf
23-
subdir = libelf-0.8.13
23+
subdir = elfutils-0.193

katran/decap/testing/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,5 @@ target_link_libraries(xdpdecap_tester
99
"${PTHREAD}"
1010
bpftester
1111
decap
12+
zstd
1213
)

0 commit comments

Comments
 (0)