Remove unused type error suppressions - opensource

Summary:
This diff was automatically generated by the Pyre per-target upgrade tool.

It removes `# pyre-fixme` or `pyrefly: ignore` comments that are no longer needed because the underlying type errors have been resolved.
Note that it will also aim to ensure type checking runs cleanly, and will add suppressions to existing type errors.

#pyreupgrade

Differential Revision: D116543228

fbshipit-source-id: 32ca0b90ec80a8a018ad879bf298554063d3c8eb

Author: generatedunixname89002005307016

build/fbcode_builder/getdeps/builder.py

@@ -51,7 +51,6 @@ def __init__(
     ) -> None:
         self.env: Env = Env()
         if env:
-            # pyre-fixme[6]: For 1st argument expected `Mapping[str, str]` but got
             #  `Env`.
             self.env.update(env)
 
@@ -118,7 +117,6 @@ def _run_cmd(
     ) -> int:
         if env:
             e = self.env.copy()
-            # pyre-fixme[6]: For 1st argument expected `Mapping[str, str]` but got
             #  `Env`.
             e.update(env)
             env = e
@@ -168,7 +166,6 @@ def _apply_patchfile(self) -> None:
         patchfile = os.path.join(
             self.build_opts.fbcode_builder_dir,
             "patches",
-            # pyre-fixme[6]: For 3rd argument expected `Union[PathLike[str], str]`
             #  but got `Optional[str]`.
             self.patchfile,
         )
@@ -437,7 +434,6 @@ def run_tests(
 
         cmd = (
             [self._make_binary, "-j%s" % self.num_jobs]
-            # pyre-fixme[58]: `+` is not supported for operand types
             #  `list[Optional[str]]` and `Optional[list[str]]`.
             + self.test_args
             + self._get_prefix()
@@ -608,7 +604,6 @@ def __init__(
 
     def _build(self, reconfigure: bool) -> None:
         env = self._compute_env()
-        # pyre-fixme[6]: For 1st argument expected `Mapping[str, str]` but got `Env`.
         meson: str | None = path_search(env, "meson")
         if meson is None:
             raise Exception("Failed to find Meson")
@@ -913,7 +908,6 @@ def _compute_cmake_define_args(self, env: Env) -> list[str]:
             # separator, so translate the runtime path to something
             # that cmake will parse
             defines["CMAKE_INSTALL_RPATH"] = ";".join(
-                # pyre-fixme[16]: Optional type has no attribute `split`.
                 env.get("DYLD_LIBRARY_PATH", "").split(":")
             )
             # Tell cmake that we want to set the rpath in the tree
@@ -986,7 +980,6 @@ def _build(self, reconfigure: bool) -> None:
             env["DESTDIR"] = self.inst_dir
 
         # Resolve the cmake that we installed
-        # pyre-fixme[6]: For 1st argument expected `Mapping[str, str]` but got `Env`.
         cmake = path_search(env, "cmake")
         if cmake is None:
             raise Exception("Failed to find CMake")
@@ -1004,7 +997,6 @@ def _build(self, reconfigure: bool) -> None:
             self._write_build_script(
                 cmd_prefix=self._get_cmd_prefix(),
                 cmake=cmake,
-                # pyre-fixme[6]: For 1st argument expected `Mapping[str, str]` but
                 #  got `Env`.
                 ctest=path_search(env, "ctest"),
                 env=env,
@@ -1050,7 +1042,6 @@ def _build_targets(self, targets: Sequence[str]) -> None:
             return
 
         env = self._compute_env()
-        # pyre-fixme[6]: For 1st argument expected `Mapping[str, str]` but got `Env`.
         cmake = path_search(env, "cmake")
         if cmake is None:
             raise RuntimeError("unable to find cmake")
@@ -1134,9 +1125,7 @@ def run_tests(
         timeout: int | None = None,
     ) -> None:
         env = self._compute_env()
-        # pyre-fixme[6]: For 1st argument expected `Mapping[str, str]` but got `Env`.
         ctest: str | None = path_search(env, "ctest")
-        # pyre-fixme[6]: For 1st argument expected `Mapping[str, str]` but got `Env`.
         cmake = path_search(env, "cmake")
 
         # Build only the missing test executables needed for the given filter.
@@ -1190,10 +1179,7 @@ def get_property(
                     return p.get("value", defval)
             return defval
 
-        # pyre-fixme[53]: Captured variable `cmake` is not annotated.
-        # pyre-fixme[53]: Captured variable `env` is not annotated.
         def list_tests() -> list[dict[str, object]]:
-            # pyrefly: ignore [no-matching-overload]
             output = subprocess.check_output(
                 [require_command(ctest, "ctest"), "--show-only=json-v1"],
                 env=env,
@@ -1258,7 +1244,6 @@ def list_tests() -> list[dict[str, object]]:
         try:
             from .facebook.testinfra import start_run
 
-            # pyre-fixme[6]: For 1st argument expected `Mapping[str, str]` but got
             #  `Env`.
             tpx = path_search(env, "tpx")
         except ImportError:
@@ -1457,7 +1442,6 @@ def _build(self, reconfigure: bool) -> None:
             bindir = os.path.join(self.loader.get_project_install_dir(m), "bin")
             add_path_entry(env, "PATH", bindir, append=False)
 
-        # pyre-fixme[6]: For 1st argument expected `Mapping[str, str]` but got `Env`.
         perl = typing.cast(str, path_search(env, "perl", "perl"))
 
         make_j_args = []
@@ -1781,7 +1765,6 @@ def _build(self, reconfigure: bool) -> None:
         env = self._compute_env()
 
         # Resolve the cmake that we installed
-        # pyre-fixme[6]: For 1st argument expected `Mapping[str, str]` but got `Env`.
         cmake = path_search(env, "cmake")
 
         # pyre-fixme[6]: For 1st argument expected `List[str]` but got

build/fbcode_builder/getdeps/buildopts.py

@@ -103,7 +103,6 @@ def __init__(
                 break
 
         # Detect what repository and project we are being run from.
-        # pyre-fixme[4]: Attribute must be annotated.
         self.repo_root, self.repo_project = detect_project(os.getcwd())
 
         # If we are running from an fbsource repository, set self.fbsource_dir
@@ -329,14 +328,11 @@ def compute_env_for_install_dirs(
                 # Try extra hard to find openssl, needed with homebrew on macOS
                 if found and p.startswith("openssl"):
                     candidate = homebrew_package_prefix("openssl@1.1")
-                    # pyre-fixme[6]: For 1st argument expected
                     #  `Union[PathLike[bytes], PathLike[str], bytes, int, str]` but got
                     #  `Optional[str]`.
                     if candidate and os.path.exists(candidate):
-                        # pyre-fixme[6]: For 2nd argument expected `str` but got
                         #  `Optional[str]`.
                         os.environ["OPENSSL_ROOT_DIR"] = candidate
-                        # pyrefly: ignore [unsupported-operation]
                         env["OPENSSL_ROOT_DIR"] = os.environ["OPENSSL_ROOT_DIR"]
 
         if self.fbsource_dir:
@@ -345,22 +341,19 @@ def compute_env_for_install_dirs(
             )
             yarn_exe = "yarn.bat" if self.is_windows() else "yarn"
             env["YARN_PATH"] = os.path.join(
-                # pyre-fixme[6]: For 1st argument expected `LiteralString` but got
                 #  `Optional[str]`.
                 self.fbsource_dir,
                 "xplat/third-party/yarn/",
                 yarn_exe,
             )
             node_exe = "node-win-x64.exe" if self.is_windows() else "node"
             env["NODE_BIN"] = os.path.join(
-                # pyre-fixme[6]: For 1st argument expected `LiteralString` but got
                 #  `Optional[str]`.
                 self.fbsource_dir,
                 "xplat/third-party/node/bin/",
                 node_exe,
             )
             env["RUST_VENDORED_CRATES_DIR"] = os.path.join(
-                # pyre-fixme[6]: For 1st argument expected `LiteralString` but got
                 #  `Optional[str]`.
                 self.fbsource_dir,
                 "third-party/rust/vendor",
@@ -496,7 +489,6 @@ def add_prefix_to_env(
                 libdir: str = os.path.join(d, lib)
                 if os.path.exists(libdir):
                     found = True
-                    # pyre-fixme[6]: For 2nd argument expected `str` but got
                     #  `Optional[str]`.
                     add_path_entry(env, self.lib_path, libdir, append=append)
                     # module detection for python is old fashioned and needs flags

build/fbcode_builder/getdeps/cargo.py

@@ -49,7 +49,6 @@ def __init__(
         )
         self.build_doc = build_doc
         self.ws_dir: str | None = workspace_dir
-        # pyre-fixme[8]: Attribute has type `Optional[List[str]]`; used as
         #  `Union[None, List[str], str]`.
         self.manifests_to_build: list[str] | None = (
             # pyrefly: ignore [bad-assignment]
@@ -205,7 +204,6 @@ def _build(self, reconfigure: bool) -> None:
                 build_args,
             )
         else:
-            # pyre-fixme[16]: Optional type has no attribute `__iter__`.
             for manifest in self.manifests_to_build:
                 self.run_cargo(
                     self.install_dirs,
@@ -245,7 +243,6 @@ def run_tests(
             if self.build_doc and not filter_args:
                 self.run_cargo(self.install_dirs, "doc", ["--no-deps"])
         else:
-            # pyre-fixme[16]: Optional type has no attribute `__iter__`.
             for manifest in self.manifests_to_build:
                 margs = ["--manifest-path", self.manifest_dir(manifest)]
                 self.run_cargo(
@@ -486,7 +483,6 @@ def _resolve_dep_to_crates(
                                     file=sys.stderr,
                                 )
                                 existing_crates.add(c)
-                        # pyre-fixme[61]: `name` is undefined, or not always defined.
                         dep_to_crates.setdefault(name, set()).update(existing_crates)
         return dep_to_crates
 

build/fbcode_builder/getdeps/copytree.py

@@ -105,7 +105,6 @@ def simple_copytree(src_dir: str, dest_dir: str, symlinks: bool = False) -> str:
 def _remove_readonly_and_try_again(
     func: Callable[..., object],
     path: str,
-    # pyre-fixme[24]: Generic type `type` expects 1 type parameter, use
     #  `typing.Type[<base type>]` to avoid runtime subscripting errors.
     exc_info: tuple[type, BaseException, object],
 ) -> None:

build/fbcode_builder/getdeps/manifest.py

@@ -950,7 +950,6 @@ def create_cargo_builder(
             src_dir,
             build_dir,
             inst_dir,
-            # pyre-fixme[6]: For 9th argument expected `bool` but got `Optional[str]`.
             build_doc,
             workspace_dir,
             manifests_to_build,

build/fbcode_builder/getdeps/py_wheel_builder.py

@@ -100,9 +100,7 @@ class PythonWheelBuilder(BuilderBase):
     that can be used by add_fb_python_library()/add_fb_python_executable() CMake rules.
     """
 
-    # pyre-fixme[13]: Attribute `dist_info_dir` is never initialized.
     dist_info_dir: str
-    # pyre-fixme[13]: Attribute `template_format_dict` is never initialized.
     template_format_dict: dict[str, str]
 
     def _build(self, reconfigure: bool) -> None:
@@ -276,7 +274,6 @@ def _parse_wheel_name(self) -> WheelNameInfo:
             platform=match.group("platform"),
         )
 
-    # pyre-fixme[24]: Generic type `email.message.Message` expects 2 type parameters.
     def _read_wheel_metadata(self, wheel_name: WheelNameInfo) -> email.message.Message:
         metadata_path = os.path.join(self.dist_info_dir, "WHEEL")
         with codecs.open(metadata_path, "r", encoding="utf-8") as f:

build/fbcode_builder/getdeps/runcmd.py

@@ -117,7 +117,6 @@ def log_to_stdout(msg: str) -> None:
     if log_file is not None:
         with open(log_file, "a", encoding="utf-8", errors="surrogateescape") as log:
 
-            # pyre-fixme[53]: Captured variable `log` is not annotated.
             def log_function(msg: str) -> None:
                 log.write(msg)
                 log_to_stdout(msg)
@@ -248,7 +247,6 @@ def _pipe_output(p: subprocess.Popen[bytes], log_fn: Callable[[str], None]) -> N
         assert p.stdout is not None
         buffer_size = 64
         while True:
-            # pyre-fixme[16]: Optional type has no attribute `read`.
             data = p.stdout.read(buffer_size)
             if not data:
                 break

build/fbcode_builder/getdeps/subcmd.py

@@ -67,11 +67,8 @@ class SubclassedCmd(cls):
             NAME = name
             HELP = help
 
-        # pyre-fixme[6]: For 1st argument expected `Type[SubCmd]` but got
         #  `Type[SubclassedCmd]`.
-        # pyre-fixme[16]: Callable `cmd` has no attribute `wrapper`.
         cmd_table.append(SubclassedCmd)
-        # pyre-fixme[7]: Expected `Type[SubCmd]` but got `Type[SubclassedCmd]`.
         return SubclassedCmd
 
     return wrapper