Remove duplicate KatranOptionalTestFixtures.h

Summary:
The KatranOptionalTestFixtures.h file was redundant because:

Tests 1-2 (ICMP Too Big) → Already exist in KatranIcmpTooBigTestFixtures.h
Tests 3-10 (LPM source lookup) → Already exist in KatranLpmSrcLookupTestFixtures.h
Tests 11-16 (Inline decap) → Similar tests exist in KatranXPopDecapTestFixtures.h
Test 17 (Local delivery) → Can be added to a dedicated fixture file if needed later

Reviewed By: p-shah256

Differential Revision: D87907608

fbshipit-source-id: f5713be560b781df7f04978fe3fd71e7ae4c2460

Author: tagrawal03

katran/lib/testing/CMakeLists.txt

@@ -45,7 +45,6 @@ add_library(bpftester STATIC
     fixtures/KatranHCTestFixtures.h
     fixtures/KatranGueTestFixtures.h
     fixtures/KatranTPRTestFixtures.h
-    fixtures/KatranOptionalTestFixtures.h
     fixtures/KatranIcmpTooBigTestFixtures.h
     fixtures/KatranLpmSrcLookupTestFixtures.h
     fixtures/KatranUdpFlowMigrationTestFixtures.h

katran/lib/testing/fixtures/KatranOptionalTestFixtures.h

@@ -27,7 +27,7 @@
 #include "katran/lib/MonitoringStructs.h"
 #include "katran/lib/testing/fixtures/KatranHCTestFixtures.h"
 #include "katran/lib/testing/fixtures/KatranIcmpTooBigTestFixtures.h"
-#include "katran/lib/testing/fixtures/KatranOptionalTestFixtures.h"
+#include "katran/lib/testing/fixtures/KatranLpmSrcLookupTestFixtures.h"
 #include "katran/lib/testing/fixtures/KatranUdpFlowMigrationTestFixtures.h"
 #include "katran/lib/testing/fixtures/KatranUdpStableRtTestFixtures.h"
 #include "katran/lib/testing/fixtures/KatranXPopDecapTestFixtures.h"
@@ -152,12 +152,20 @@ void runTestsFromFixture(
     prepareOptionalLbData(lb);
     LOG(INFO) << "Running optional tests. they could fail if requirements "
               << "are not satisfied";
+    // Run ICMP Too Big tests (requires ICMP_TOOBIG_GENERATION and kernel 4.17+)
     if (FLAGS_gue) {
-      tester.resetTestFixtures(katran::testing::icmpTooBigTestFixtures);
+      LOG(INFO) << "Running ICMP Too Big tests for Origin GUE";
+      tester.resetTestFixtures(
+          katran::testing::originGueIcmpTooBigTestFixtures);
     } else {
-      tester.resetTestFixtures(katran::testing::optionalTestFixtures);
+      LOG(INFO) << "Running ICMP Too Big tests";
+      tester.resetTestFixtures(katran::testing::icmpTooBigTestFixtures);
     }
     tester.testFromFixture();
+    // Run LPM source lookup tests (requires LPM_SRC_LOOKUP)
+    LOG(INFO) << "Running LPM source lookup tests";
+    tester.resetTestFixtures(katran::testing::lpmSrcLookupTestFixtures);
+    tester.testFromFixture();
     testOptionalLbCounters(lb, testParam);
   }
   if (FLAGS_stable_rt) {