Skip to content

Commit 4e3dbf7

Browse files
nikhildl12facebook-github-bot
authored andcommitted
Fix ignoring_due_to_kde stat
Summary: TPR skips due to KDE in 2 places. We were not incrementing this stat in one of those places, hence missing the stat increase while debugging TPR issue. Fixing it Reviewed By: frankfeir Differential Revision: D79908694 fbshipit-source-id: fa44834e38be486bbb7f8a2ce37dddd1109d17cc
1 parent 28cb03b commit 4e3dbf7

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

katran/tpr/bpf/tcp_pkt_router.bpf.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,13 @@ static inline int handle_passive_cb(
3737
case BPF_SOCK_OPS_HDR_OPT_LEN_CB:
3838
/* Reserve space for writing the header option later in
3939
* BPF_SOCK_OPS_WRITE_HDR_OPT_CB. */
40-
if (((skops->skb_tcp_flags & TCPHDR_SYNACK) == TCPHDR_SYNACK) &&
41-
!should_ignore_due_to_kde(skops)) {
40+
if ((skops->skb_tcp_flags & TCPHDR_SYNACK) == TCPHDR_SYNACK) {
41+
if (should_ignore_due_to_kde(skops)) {
42+
stat->ignoring_due_to_kde++;
43+
return SUCCESS;
44+
}
4245
return handle_hdr_opt_len(skops, stat);
46+
4347
} else {
4448
return SUCCESS;
4549
}

0 commit comments

Comments
 (0)