You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bump fbcode_builder getdeps manifest pins past CMake-4 floor
Summary:
Bump seven `fbcode_builder/manifests/*` pins to current upstream releases. All pinned versions were 5–7 years old and declared `cmake_minimum_required(VERSION <3.5)`, which CMake 4.0 (March 2025) hard-removed compatibility for. Downstream OSS consumers (folly, fbthrift, eden, watchman, mvfst, wangle, fizz, rebalancer) had been working around this by injecting `-DCMAKE_POLICY_VERSION_MINIMUM=3.5` into every per-dep configure line. That workaround silently flips ~10 CMake policies between 2.8 and 3.5 to NEW behavior on every build — exactly the policy churn `cmake_minimum_required` was designed to make explicit and reviewable. The clean fix is to bump the manifest pins; all picked versions raise their CMake floor above 3.5.
Bumps:
- double-conversion v3.1.4 → pinned `[git]` rev ddfd18c5. Switched from `[download]` to `[git]` because the only released version with a CMake floor above 3.5 is v3.4.0, which jumped the floor all the way to 3.29 — above the CMake 3.20 that getdeps ships. ddfd18c5 is a master commit predating the 3.29 bump while still satisfying the CMake 4 floor, so consumer workflows don't need `CMAKE_POLICY_VERSION_MINIMUM=3.5` for double-conversion either.
- gflags v2.2.2 → v2.3.0 (cmake floor 3.10)
- glog v0.5.0 → v0.6.0 pinned `[git]` rev b33e3bad (cmake floor 3.16). Switched from `[download]` to `[git]` because v0.7.1 raises cmake_minimum_required to 3.22, above the CMake 3.20.4 that getdeps ships on darwin; v0.6.0 sets the floor at 3.16 which is within range.
- libevent release-2.1.12-stable → pinned `[git]` rev 48296514 (cmake floor 3.15). Switched from `[download]` to `[git]` because the most recent tagged release is the one we're already on; release-2.2.x is still alpha. Pinning a specific master commit (not the branch) keeps the build deterministic.
- snappy 1.1.7 → 1.2.2 (cmake floor 3.10)
- xxhash v0.8.2 → v0.8.3 (cmake floor 3.10)
- zstd v1.5.5 → v1.5.7 (cmake floor 3.10)
Also drops the `CMAKE_POLICY_VERSION_MINIMUM=3.5` workaround from `fbcode/algopt/rebalancer/oss_root/tools/wheels/before_all_{linux,macos}.sh` — the only fbsource-internal carriers of the workaround. The corresponding hand-edits in OSS folly/fbthrift/eden/watchman/mvfst/wangle/fizz workflows live in their respective github mirrors, not in fbsource, and need follow-up PRs there once these bumps propagate via shipit.
Reviewed By: xiatingouyang
Differential Revision: D104478389
fbshipit-source-id: e16204d438c4e6ec868574594a3cf29bc96b217d
0 commit comments