renable github actions for linux

Summary:
X-link: facebook/sapling#1135

Renable mononoke linux github actions so that folks externally can see that it current builds, and so they can see the breaks easily if it later doesn't build.

Added support for pinning rust version as during developement needed to pin to rust 1.90 as didn't yet compile with 1.91. In the meantime 1.91 support landed so pinned to 1.91.

Also saw that it was running out of disk space on the github actions runner so switched it to use MinSizeRel cmake build type and added a cargo mapping for it

Reviewed By: genevievehelsel

Differential Revision: D82818583

fbshipit-source-id: 6f0c54caa5b9593135a6977b1409f416ca622d81

Author: ahornby

build/fbcode_builder/getdeps.py

@@ -964,6 +964,13 @@ def setup_project_cmd_parser(self, parser):
             default=None,
             help="Timeout in seconds for each individual test",
         )
+        parser.add_argument(
+            "--build-type",
+            help="Set the build type explicitly.  Cmake and cargo builders act on them. Only Debug and RelWithDebInfo widely supported.",
+            choices=["Debug", "Release", "RelWithDebInfo", "MinSizeRel"],
+            action="store",
+            default=None,
+        )
 
 
 @cmd(
@@ -1049,6 +1056,13 @@ def write_job_for_platform(self, platform, args):  # noqa: C901
             args.enable_tests
             and manifest.get("github.actions", "run_tests", ctx=manifest_ctx) != "off"
         )
+        rust_version = (
+            manifest.get("github.actions", "rust_version", ctx=manifest_ctx) or "stable"
+        )
+
+        override_build_type = args.build_type or manifest.get(
+            "github.actions", "build_type", ctx=manifest_ctx
+        )
         if run_tests:
             manifest_ctx.set("test", "on")
         run_on = self.get_run_on(args)
@@ -1163,8 +1177,8 @@ def write_job_for_platform(self, platform, args):  # noqa: C901
             out.write("    - uses: actions/checkout@v4\n")
 
             build_type_arg = ""
-            if args.build_type:
-                build_type_arg = f"--build-type {args.build_type} "
+            if override_build_type:
+                build_type_arg = f"--build-type {override_build_type} "
 
             if build_opts.free_up_disk:
                 free_up_disk = "--free-up-disk "
@@ -1241,8 +1255,8 @@ def write_job_for_platform(self, platform, args):  # noqa: C901
                     or builder_name == "cargo"
                     or mbuilder_name == "cargo"
                 ):
-                    out.write("    - name: Install Rust Stable\n")
-                    out.write("      uses: dtolnay/rust-toolchain@stable\n")
+                    out.write(f"    - name: Install Rust {rust_version.capitalize()}\n")
+                    out.write(f"      uses: dtolnay/rust-toolchain@{rust_version}\n")
                     break
 
             # Normal deps that have manifests
@@ -1360,7 +1374,7 @@ def write_job_for_platform(self, platform, args):  # noqa: C901
 
                 out.write("    - name: Test %s\n" % manifest.name)
                 out.write(
-                    f"      run: {getdepscmd}{allow_sys_arg} test {num_jobs_arg}--src-dir=. {manifest.name}{project_prefix}\n"
+                    f"      run: {getdepscmd}{allow_sys_arg} test {build_type_arg}{num_jobs_arg}--src-dir=. {manifest.name}{project_prefix}\n"
                 )
             if build_opts.free_up_disk and not build_opts.is_windows():
                 out.write("    - name: Show disk space at end\n")

build/fbcode_builder/getdeps/cargo.py

@@ -95,7 +95,7 @@ def cargo_config_file(self):
         if self.cargo_config_file_subdir:
             return os.path.join(build_source_dir, self.cargo_config_file_subdir)
         else:
-            return os.path.join(build_source_dir, ".cargo", "config")
+            return os.path.join(build_source_dir, ".cargo", "config.toml")
 
     def _create_cargo_config(self):
         cargo_config_file = self.cargo_config_file()
@@ -122,8 +122,12 @@ def _create_cargo_config(self):
 [profile.dev]
 debug = false
 incremental = false
+
+[profile.release]
+opt-level = "{}"
 """.format(
-                self.build_dir.replace("\\", "\\\\")
+                self.build_dir.replace("\\", "\\\\"),
+                "z" if self.build_opts.build_type == "MinSizeRel" else "s",
             )
 
         # Point to vendored sources from getdeps manifests
@@ -173,7 +177,7 @@ def _build(self, reconfigure) -> None:
         build_source_dir = self.build_source_dir()
 
         build_args = [
-            "--out-dir",
+            "--artifact-dir",
             os.path.join(self.inst_dir, "bin"),
             "-Zunstable-options",
         ]
@@ -206,20 +210,26 @@ def _build(self, reconfigure) -> None:
     def run_tests(
         self, schedule_type, owner, test_filter, retry, no_testpilot, timeout=None
     ) -> None:
+        build_args = []
+        if self.build_opts.build_type != "Debug":
+            build_args.append("--release")
+
         if test_filter:
-            args = ["--", test_filter]
+            filter_args = ["--", test_filter]
         else:
-            args = []
+            filter_args = []
 
         if self.manifests_to_build is None:
-            self.run_cargo(self.install_dirs, "test", args)
-            if self.build_doc:
+            self.run_cargo(self.install_dirs, "test", build_args + filter_args)
+            if self.build_doc and not filter_args:
                 self.run_cargo(self.install_dirs, "doc", ["--no-deps"])
         else:
             for manifest in self.manifests_to_build:
                 margs = ["--manifest-path", self.manifest_dir(manifest)]
-                self.run_cargo(self.install_dirs, "test", args + margs)
-                if self.build_doc:
+                self.run_cargo(
+                    self.install_dirs, "test", build_args + filter_args + margs
+                )
+                if self.build_doc and not filter_args:
                     self.run_cargo(self.install_dirs, "doc", ["--no-deps"] + margs)
 
     def _patchup_workspace(self, dep_to_git) -> None:

build/fbcode_builder/getdeps/manifest.py

@@ -98,6 +98,8 @@
         "fields": {
             "run_tests": OPTIONAL,
             "required_locales": OPTIONAL,
+            "rust_version": OPTIONAL,
+            "build_type": OPTIONAL,
         },
     },
     "crate.pathmap": {"optional_section": True},

build/fbcode_builder/manifests/mononoke

@@ -18,6 +18,10 @@ builder = nop
 build_doc = true
 workspace_dir = eden/mononoke
 
+[github.actions]
+rust_version = 1.91
+build_type = MinSizeRel
+
 [shipit.pathmap]
 fbcode/configerator/structs/scm/hg = configerator/structs/scm/hg
 fbcode/configerator/structs/scm/hg/public_autocargo = configerator/structs/scm/hg