Commit 5e30213
Pin cibuildwheel and install libzstd in release workflow
Summary:
Two related fixes to `.github/workflows/release.yml` so the release workflow
can actually build wheels. Replaces the earlier broken `pypa/cibuildwheel@v2`
reference (cibuildwheel does not publish a rolling major-only tag — the error
was `Error: Unable to resolve action pypa/cibuildwheel@v2, unable to find
version v2`).
1. **Pin cibuildwheel to `v3.4.1`**. cibuildwheel tags all real releases as
full semver (`v3.4.1`, `v2.23.2`, ...) and minor-rolling (`v3.4`, `v3.3`),
but no major-rolling tag exists. v3.4.1 matches what other fbsource
release workflows (e.g. arvr/momentum) use today, and v3 is a drop-in for
our config (`CIBW_BUILD`, `CIBW_SKIP`, `CIBW_ARCHS_MACOS` unchanged).
2. **Install libzstd at build time** via `CIBW_BEFORE_ALL_LINUX` and
`CIBW_BEFORE_ALL_MACOS`. The sibling `ci.yml` already installs
`libzstd-dev` / `brew install zstd` on its host runners, but release.yml
builds inside the manylinux2014 container (Linux) or on a fresh
macos-latest runner, neither of which has zstd development headers
available. Without this, the C++ extension compile would fail after the
action-resolve fix.
Caveats and likely next issues:
- The macOS x86_64 cross-compile leg may still fail to link against zstd if
brew only provides an arm64 build on macos-latest runners. If that shows up,
remediation options are: (a) drop x86_64 from CIBW_ARCHS_MACOS (arm64-only
wheels), (b) build zstd from source per-arch inside the cibuildwheel
container.
- `yum install libzstd-devel` on manylinux2014 is fine (EPEL/default repo);
if cibuildwheel bumps the manylinux image default to manylinux_2_28
(CentOS Stream 9 base), this still works because libzstd-devel is in the
default AppStream repo there too.
Reviewed By: youngd007
Differential Revision: D103457641
fbshipit-source-id: 9bfb0557562535cfda575ba697254e41941537ec1 parent a3aef46 commit 5e30213
1 file changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
62 | 69 | | |
63 | 70 | | |
64 | 71 | | |
| |||
0 commit comments