Skip to content

Commit bb41b08

Browse files
pdepetrometa-codesync[bot]
authored andcommitted
Fix stale comments referencing deleted launchers
Summary: Doc/comment-only cleanup of references to the now-deleted `offline_postmortem` and `tintype_debug_launcher` binaries. - `tintype/fb/runtime_paths.py`: drop the `offline_postmortem` / serialization mentions from the docstring; `get_runtime_path` is now shared only with the debugpy adapter. - `tintype/dap/cli.py`: remove the "separate from the legacy pydevd-based `tintype_debug_launcher`" sentence. - `tintype/fb/BUCK`: reword the `tintype_dap_server` comment that referenced matching `tintype_debug_launcher`. - `tintype/snapshot_lib/SnapshotReader.cpp`: reword the mkstemp comment's example (a sibling process reading the same `.pytb`) which named `tintype_debug_launcher`. No behavior change. Reviewed By: piyushjaiswal98 Differential Revision: D114678766 fbshipit-source-id: a5f49c5142b1001aeb79bfbfd729953e194b302d
1 parent 16844a4 commit bb41b08

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

dap/cli.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@
77
"""CLI entry point for the tintype DAP server.
88
99
Dedicated binary (``tintype_dap_server``) that serves a ``.pytb``
10-
snapshot over the Debug Adapter Protocol. Separate from the legacy
11-
pydevd-based ``tintype_debug_launcher`` so the two flows don't share a
12-
dispatch branch.
10+
snapshot over the Debug Adapter Protocol.
1311
1412
Transport:
1513

snapshot_lib/SnapshotReader.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,9 @@ bool SnapshotReader::open(const std::string& path) {
153153

154154
// Create a unique temporary file for the decompressed data.
155155
// mkstemp guarantees a fresh path so concurrent readers of the same
156-
// compressed source file (e.g., a sibling process attaching
157-
// tintype_debug_launcher to the same .pytb) cannot collide on this temp
158-
// file. With a shared name, one reader's O_TRUNC + ftruncate corrupts
156+
// compressed source file (e.g., a sibling process reading the same
157+
// .pytb) cannot collide on this temp file. With a shared name, one
158+
// reader's O_TRUNC + ftruncate corrupts
159159
// another reader's MAP_SHARED mmap (zero-fills the buffer through the
160160
// shared inode) — see SnapshotWriter::open which already uses mkstemp
161161
// for the same reason.

0 commit comments

Comments
 (0)