Commit c1908c3
Pin MACOSX_DEPLOYMENT_TARGET on the OSS CI macOS
Summary:
The OSS CI macOS legs are failing to compile snapshot_lib/SnapshotReader.cpp
on Xcode 16.4:
error: 'is_absolute' is unavailable: introduced in macOS 10.15 unknown
if (src.is_absolute()) { ... }
^
note: 'is_absolute' has been explicitly marked unavailable here
_LIBCPP_HIDE_FROM_ABI bool is_absolute() const { ... }
^
Cause: the Python.org universal2 frameworks that actions/setup-python@v5
installs for 3.12+ declare a MACOSX_DEPLOYMENT_TARGET of 10.13 in
sysconfig (x86_64 slice). setuptools propagates that into the C++
extension build via -mmacosx-version-min=10.13, which is below the 10.15
floor where libc++ marks std::filesystem::path symbols available, so
the compiler refuses any use of is_absolute(), the path destructor,
etc.
This diff sets MACOSX_DEPLOYMENT_TARGET=11.0 at the build-and-test job
level so the env var is in scope before setup-python runs and before
\`pip install -v .\` builds the extension. 11.0 (rather than the 10.15
strictly required by std::filesystem) matches release.yml's wheel
target (CIBW_ENVIRONMENT_MACOS, line 91), so CI builds against the
same ABI floor as the wheels we publish to PyPI. The env var is
ignored on the Linux matrix legs, so no special-casing is needed.
Reviewed By: pdepetro
Differential Revision: D104851472
fbshipit-source-id: 1a962a4dacf4ad8448ee30b7fbf388a26dd327711 parent c874ad7 commit c1908c3
1 file changed
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
20 | 28 | | |
21 | 29 | | |
22 | 30 | | |
| |||
0 commit comments