Skip to content

Commit fb24c2f

Browse files
itamarometa-codesync[bot]
authored andcommitted
Cleanup 3.13t references in tintype
Summary: Update tintype files to reference 3.14t instead of 3.13t for free-threaded Python. This is part of the Python 3.13 cleanup following the completion of the 3.13 deletion. ___ overriding_review_checks_triggers_an_audit_and_retroactive_review Oncall Short Name: plf Differential Revision: D104294262 fbshipit-source-id: 4229f519795e40541abd95e33586677349082c48
1 parent ff70c60 commit fb24c2f

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

snapshot_lib/SnapshotCapture.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ std::vector<std::pair<std::string, uint64_t>> extractLocalVars(
9898
// py::reinterpret_borrow creates a py::object that borrows the reference,
9999
// but when pushed to processingQueue, the copy constructor INCREFs.
100100
// This ensures the object stays alive during serialization.
101-
// Note: In free-threaded Python (3.13t+), other threads may continue
101+
// Note: In free-threaded Python (3.14t+), other threads may continue
102102
// executing and could mutate objects, but they won't be destroyed while
103103
// we hold this reference.
104104
processingQueue.emplace_back(py::reinterpret_borrow<py::object>(value), 0);
@@ -2313,7 +2313,7 @@ void SnapshotCapture::sampleSingleThread(
23132313
bool alreadyHoldsLock) {
23142314
// Directly capture the target thread using sys._current_frames().
23152315
// The GIL is held by samplingLoop() via PyGILState_Ensure().
2316-
// Note: In free-threaded Python (3.13t+), other threads continue executing
2316+
// Note: In free-threaded Python (3.14t+), other threads continue executing
23172317
// even with GIL held - we hold references to prevent object destruction,
23182318
// but object state may be mutated during serialization.
23192319

snapshot_lib/SnapshotCapture.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ class SnapshotCapture {
325325
* Called by snapshotAllThreads() to capture all thread stacks.
326326
*
327327
* In standard Python, the GIL is held throughout, so other Python threads
328-
* are paused and objects are stable. In free-threaded Python (3.13t+),
328+
* are paused and objects are stable. In free-threaded Python (3.14t+),
329329
* other threads continue executing - we hold references to prevent object
330330
* destruction, but object state may be mutated during serialization.
331331
*
@@ -405,7 +405,7 @@ class SnapshotCapture {
405405
* Called from samplingLoop() with the GIL held. Uses sys._current_frames()
406406
* to directly capture the target thread's frame.
407407
*
408-
* Note: In free-threaded Python (3.13t+), other threads continue executing
408+
* Note: In free-threaded Python (3.14t+), other threads continue executing
409409
* even with GIL held - we hold references to prevent object destruction,
410410
* but object state may be mutated during serialization.
411411
*/

tests/test_all_threads.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
import tintype
1818

19-
# Check if we're running in free-threaded Python (3.13t+)
19+
# Check if we're running in free-threaded Python (3.14t+)
2020
# snapshot_all_threads is disabled in free-threaded Python due to potential deadlocks
2121
IS_FREE_THREADED: bool = hasattr(sys, "_is_gil_enabled") and not sys._is_gil_enabled()
2222

tests/test_sampling.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import tintype
1818
from tintype._sampling import disable_sampling, enable_sampling, sampling, SamplingMode
1919

20-
# Check if we're running in free-threaded Python (3.13t+)
20+
# Check if we're running in free-threaded Python (3.14t+)
2121
# Sampling is disabled in free-threaded Python due to potential deadlocks
2222
IS_FREE_THREADED: bool = hasattr(sys, "_is_gil_enabled") and not sys._is_gil_enabled()
2323

0 commit comments

Comments
 (0)