You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here it looks like a bug. Because folly doesn't have such xor, it will lead to same zero hash for any zero bytes input. Maybe it's not an issue if such input is impossible, but it's still quite complicated usage without xor with ~0U
Also here is two, symmetric, usage, they're probably correct, but it's not crc32c isn't it?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
In general folly::crc32c have quite strange API, you need to mix it with
~0Umanually.For an example like here
Other implementations like abseil and rocksdb tries to avoid it:
Here it looks like a bug. Because folly doesn't have such xor, it will lead to same zero hash for any zero bytes input. Maybe it's not an issue if such input is impossible, but it's still quite complicated usage without xor with
~0UAlso here is two, symmetric, usage, they're probably correct, but it's not crc32c isn't it?
Beta Was this translation helpful? Give feedback.
All reactions