Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lt, lte, gt, gte, neq, between for UUID type #10584

Open
aditi-pandit opened this issue Jul 26, 2024 · 5 comments
Open

Add lt, lte, gt, gte, neq, between for UUID type #10584

aditi-pandit opened this issue Jul 26, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@aditi-pandit
Copy link
Collaborator

Description

Presto UUID type supports neq, lt, lte, gt, gte, between operations UUIDOperators

This allows more flexible use in SQL.

The lack of these operators causes exceptions today
https://github.com/prestodb/presto/pull/23301/files#r1693434020

Since we support equality on UUID, it seems strange not to support the rest of these operations.

@aditi-pandit aditi-pandit added the enhancement New feature or request label Jul 26, 2024
@aditi-pandit
Copy link
Collaborator Author

@mbasmanova : Any particular reason we don't support these ? Don't think this has the logical type comparison issue as Timestamp with Timezone.

@BryanCutler
Copy link

Hi @aditi-pandit I'll work on this one

@mbasmanova
Copy link
Contributor

@aditi-pandit No particular reason. Let's add missing functionality.

@BryanCutler Thank you for offering to work on this.

@mbasmanova
Copy link
Contributor

CC: @amitkdutta

@BryanCutler
Copy link

Just a quick update - I have the basic implementation done for comparisons, working on adding tests and will put up a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants