feat(spill): Add row_number_spill_file_create_config for RowNumber operator (#16802)#16802
Closed
tanjialiang wants to merge 1 commit intofacebookincubator:mainfrom
Closed
feat(spill): Add row_number_spill_file_create_config for RowNumber operator (#16802)#16802tanjialiang wants to merge 1 commit intofacebookincubator:mainfrom
tanjialiang wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@tanjialiang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96842896. |
✅ Deploy Preview for meta-velox canceled.
|
meta-codesync
bot
changed the title
tanjialiang
added a commit
to tanjialiang/velox-1
that referenced
this pull request
Mar 17, 2026
…erator (facebookincubator#16802) Summary: RowNumber operator uses partitioned spilling (similar to HashBuild and HashAggregation) which can result in high concurrent file write fan-out. This adds a dedicated spill file create config for RowNumber so that file buffer sizes can be tuned independently from other operators. This follows the same pattern as the existing aggregation_spill_file_create_config and hash_join_spill_file_create_config. Differential Revision: D96842896
tanjialiang
force-pushed
the
export-D96842896
branch
from
60fe1e6 to
5e03724
Compare
tanjialiang
added a commit
to tanjialiang/velox-1
that referenced
this pull request
Mar 17, 2026
…erator (facebookincubator#16802) Summary: Pull Request resolved: facebookincubator#16802 RowNumber operator uses partitioned spilling (similar to HashBuild and HashAggregation) which can result in high concurrent file write fan-out. This adds a dedicated spill file create config for RowNumber so that file buffer sizes can be tuned independently from other operators. This follows the same pattern as the existing aggregation_spill_file_create_config and hash_join_spill_file_create_config. Differential Revision: D96842896
tanjialiang
force-pushed
the
export-D96842896
branch
from
5e03724 to
a42dd07
Compare
…erator (facebookincubator#16802) Summary: RowNumber operator uses partitioned spilling (similar to HashBuild and HashAggregation) which can result in high concurrent file write fan-out. This adds a dedicated spill file create config for RowNumber so that file buffer sizes can be tuned independently from other operators. This follows the same pattern as the existing aggregation_spill_file_create_config and hash_join_spill_file_create_config. Reviewed By: duxiao1212 Differential Revision: D96842896
tanjialiang
force-pushed
the
export-D96842896
branch
from
a42dd07 to
9ddcc09
Compare
|
This pull request has been merged in 0b7f909. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RowNumber operator uses partitioned spilling (similar to HashBuild and
HashAggregation) which can result in high concurrent file write fan-out.
This adds a dedicated spill file create config for RowNumber so that
file buffer sizes can be tuned independently from other operators.
This follows the same pattern as the existing
aggregation_spill_file_create_config and hash_join_spill_file_create_config.
Reviewed By: duxiao1212
Differential Revision: D96842896